[v20.x backport]deps: V8: cherry-pick 6b1b9bca2a8 #59662
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Origin commit message:
[loong64][codegen] Avoid memory access under stack pointer
According to LoongArch ABI doc chapter 8.2:
"Procedures must not assume the persistence on-stack data of which
the addresses lie below the stack pointer."
Change-Id: I92735e052227495ac9884c4290b57eaffbf905e1
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6786372
Auto-Submit: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn>
Reviewed-by: Matthias Liedtke <mliedtke@chromium.org>
Commit-Queue: Matthias Liedtke <mliedtke@chromium.org>
Cr-Commit-Position: refs/heads/main@{#101634}
Refs: v8/v8@6b1b9bc
Collaborator
|
Review requested:
|
nodejs-github-bot
added
build
marco-ippolito
approved these changes
Aug 28, 2025
marco-ippolito
added
the
request-ci
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
Contributor
Author
|
https://ci.nodejs.org/job/node-test-commit-osx/66558/nodes=osx13-arm64/console |
Collaborator
Collaborator
Collaborator
Member
|
The only test failing is unrelated to this PR, I'll backport it |
marco-ippolito
pushed a commit
that referenced
this pull request
Sep 2, 2025
Origin commit message:
[loong64][codegen] Avoid memory access under stack pointer
According to LoongArch ABI doc chapter 8.2:
"Procedures must not assume the persistence on-stack data of which
the addresses lie below the stack pointer."
Change-Id: I92735e052227495ac9884c4290b57eaffbf905e1
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6786372
Auto-Submit: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn>
Reviewed-by: Matthias Liedtke <mliedtke@chromium.org>
Commit-Queue: Matthias Liedtke <mliedtke@chromium.org>
Cr-Commit-Position: refs/heads/main@{#101634}
Backport-PR-URL: #59662
Refs: v8/v8@6b1b9bc
PR-URL: #59283
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Member
|
Landed in 42224ac |
Member
|
It actually needs to wait to land v24 first, so we gotta wait for the next release :( |
marco-ippolito
force-pushed
the
v20.x-staging
branch
from
78f1233 to
2f333b6
Compare
Contributor
Author
|
Due to the changes to v8_embedder_string in common.gypi, there may be conflicts when cherry-picking from the main branch to v24.x. |
Member
|
No we just have that the commits get released in a v24 to make sure it does not break ecosystem then we can backport it to an lts release |
Contributor
Author
|
Thank you for your reply, I'll keep an eye on the progress. |
Contributor
Author
|
This fix has been incorporated into the v24.8.0 release (#59816) @marco-ippolito |
marco-ippolito
pushed a commit
that referenced
this pull request
Nov 19, 2025
Origin commit message:
[loong64][codegen] Avoid memory access under stack pointer
According to LoongArch ABI doc chapter 8.2:
"Procedures must not assume the persistence on-stack data of which
the addresses lie below the stack pointer."
Change-Id: I92735e052227495ac9884c4290b57eaffbf905e1
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6786372
Auto-Submit: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn>
Reviewed-by: Matthias Liedtke <mliedtke@chromium.org>
Commit-Queue: Matthias Liedtke <mliedtke@chromium.org>
Cr-Commit-Position: refs/heads/main@{#101634}
Backport-PR-URL: #59662
Refs: v8/v8@6b1b9bc
PR-URL: #59283
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Member
|
Landed in acec799 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #59283 to v20.x.
Fix node-20.19.0 cpu-prof test failures can be seen in Debian CI:
https://buildd.debian.org/status/fetch.php?pkg=nodejs&arch=loong64&ver=20.19.0%2Bdfsg-2&stamp=1743722073&raw=0
CC: @marco-ippolito @aduh95