Skip to content

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Dec 30, 2025

Having import { path } from '../common/fixtures.mjs results in path to refer to a function, which is confusing as it more often refers to node:path. In general, most utils of this module benefits from being prefixed with fixtures. (i.e. fileURL(…) vs fixtures.fileURL(…)).

Refs: #61089 (comment)

@nodejs-github-bot nodejs-github-bot added addons Issues and PRs related to native addons. esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Dec 30, 2025
@codecov
Copy link

codecov bot commented Dec 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.53%. Comparing base (7b7f693) to head (569a684).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #61228      +/-   ##
==========================================
- Coverage   88.54%   88.53%   -0.02%     
==========================================
  Files         704      704              
  Lines      208738   208738              
  Branches    40278    40273       -5     
==========================================
- Hits       184833   184806      -27     
- Misses      15914    15952      +38     
+ Partials     7991     7980      -11     

see 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

addons Issues and PRs related to native addons. esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants