test: unify assertSnapshot stacktrace transform #61665
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61665 +/- ##
==========================================
+ Coverage 89.74% 89.75% +0.01%
==========================================
Files 675 675
Lines 204601 204642 +41
Branches 39325 39323 -2
==========================================
+ Hits 183616 183681 +65
+ Misses 13273 13234 -39
- Partials 7712 7727 +15 🚀 New features to boost your workflow:
|
legendecas
force-pushed
the
test-assert-snapshot-stack
branch
from
d0d45b2 to
9f7ada0
Compare
legendecas
commented
Feb 4, 2026
| ); | ||
|
|
||
| // eslint-disable-next-line no-control-regex | ||
| child.stdout.on('data', (d) => process.stdout.write(d.toString().replace(/[^\x00-\x7F]/g, '').replace(/\u001b\[\d+m/g, ''))); |
Member
Author
There was a problem hiding this comment.
This was basically skipping the test of unusual chars in CWD on the CI.
legendecas
force-pushed
the
test-assert-snapshot-stack
branch
from
5c4203b to
d72d40b
Compare
Member
Author
|
@nodejs/test_runner would you mind taking a look at this? Thank you! |
MoLow
approved these changes
Feb 9, 2026
Member
MoLow
left a comment
MoLow
left a comment
There was a problem hiding this comment.
Amazing work. I wonder if we should expose some of this on node:util
pmarchini
approved these changes
Feb 9, 2026
github-actions
bot
removed
the
request-ci
Collaborator
legendecas
force-pushed
the
test-assert-snapshot-stack
branch
3 times, most recently
from
4b94f49 to
9903cf5
Compare
Member
Author
|
Rebased to address conflicts. |
legendecas
force-pushed
the
test-assert-snapshot-stack
branch
from
9903cf5 to
8393c87
Compare
Collaborator
The snapshotted stack frames should hide node internal stack frames so that general node core development does not need updating the snapshot. For userland stack frames, they are highly fixture related and any fixture change should reflect in a change of the snapshot. Additionally, the line and column number are highly relevant to the correctness of the snapshot, these should not be redacted. A change in node core that affects userland stack frames should be alarming and be reflected in the snapshots. Features like test runner and source map support both should snapshot userland stack frames to ensure that userland code locations are computed correctly.
legendecas
force-pushed
the
test-assert-snapshot-stack
branch
from
8393c87 to
c2dc969
Compare
Collaborator
Collaborator
Member
Author
|
@MoLow @pmarchini CI is now green, would you mind taking another look? Thank you! |
pmarchini
approved these changes
Feb 10, 2026
legendecas
added
the
author ready
MoLow
approved these changes
Feb 11, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The snapshotted stack frames should hide node internal stack frames so
that general node core development does not need updating the snapshot.
Internal stack frames are replaced with
at <node-internal-frames>.For userland stack frames, they are highly fixture related and any
fixture change should reflect in a change of the snapshot. Additionally,
the line and column number are highly relevant to the correctness of the
snapshot, these should not be redacted. A change in node core that
affects userland stack frames should be alarming and be reflected in the
snapshots.
Features like test runner and source map support both should snapshot
userland stack frames to ensure that userland code locations are
computed correctly.