fix(ci): skip workflow publish when no packages found#8454
fix(ci): skip workflow publish when no packages found#8454ovflowd merged 2 commits intonodejs:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
👋 Codeowner Review RequestThe following codeowners have been identified for the changed files: Team reviewers: @nodejs/web-infra Please review the changes when you have a chance. Thank you! 🙏 |
There was a problem hiding this comment.
Pull request overview
This PR addresses a workflow failure that occurs when the publish-packages workflow is triggered but no packages actually need to be published. The fix adds a conditional check to skip the publish job when the package matrix is empty.
Key Changes
- Added conditional check to skip the
publishjob when no packages need publishing - The condition verifies that the first element of the package array is not null before proceeding
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Lighthouse Results
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8454 +/- ##
==========================================
+ Coverage 73.78% 73.81% +0.03%
==========================================
Files 109 109
Lines 9255 9255
Branches 314 313 -1
==========================================
+ Hits 6829 6832 +3
+ Misses 2424 2421 -3
Partials 2 2 ☔ View full report in Codecov by Sentry. |
|
@nodejs/web-infra fast-tracking the PR as a minor fix. |
Description
This PR fixes the publish package failure issue when no change in packages directory.
Validation
Related Issues
Issue - #8453
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.