fix(a11y): wrap SidebarItem with <li> in SidebarGroup#8515
Merged
avivkeller merged 2 commits intonodejs:mainfrom Jan 5, 2026
Merged
fix(a11y): wrap SidebarItem with <li> in SidebarGroup#8515avivkeller merged 2 commits intonodejs:mainfrom
avivkeller merged 2 commits intonodejs:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
👋 Codeowner Review RequestThe following codeowners have been identified for the changed files: Team reviewers: @nodejs/nodejs-website Please review the changes when you have a chance. Thank you! 🙏 |
mikeesto
approved these changes
Jan 3, 2026
Contributor
|
Lighthouse Results
|
avivkeller
reviewed
Jan 3, 2026
packages/ui-components/src/Containers/Sidebar/SidebarGroup/index.tsx
Outdated
Show resolved
Hide resolved
avivkeller
approved these changes
Jan 4, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8515 +/- ##
==========================================
+ Coverage 74.21% 74.24% +0.03%
==========================================
Files 106 106
Lines 9102 9102
Branches 308 307 -1
==========================================
+ Hits 6755 6758 +3
+ Misses 2345 2342 -3
Partials 2 2 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an accessibility issue in the
Sidebarnavigation.Currently, sidebar items are placed directly inside
<ul>without<li>wrappers, which breaks HTML list rules and causes accessibility errors.Validation
Before the fix (invalid – direct
<a>inside<ul>):After the fix (correct – wrapped in
<li>):Related Issues
#8465
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.