CII-Best-Practices for Nodejs: Silver level by UlisesGascon · Pull Request #955 · nodejs/security-wg

UlisesGascon · 2023-04-16T16:06:42Z

Related #953

This pull request contains a dump of the current questions and answers for the Node.js project in OpenSSF Best Practices for Silver Level. The purpose is to review the current answers, update and comment on them until we have a final version, and then update the OpenSSF Best Practices site.

tools/ossf_best_practices/silver_criteria.md

ref: nodejs#955 (comment)

UlisesGascon

@nodejs/security I closed the previous discussions and I added new ones.

The new ones are the last step before we can merge it 🙌

tools/ossf_best_practices/silver_criteria.md

ref: nodejs#955 (comment)

Ref: nodejs#955 (comment)

ref: nodejs#955 (comment)

Ref: nodejs#955 (comment)

… feat/best-practices-silver

ref: nodejs#955 (comment)

UlisesGascon · 2023-07-31T13:00:13Z

Ok, so we managed to close all the discussions! 🎉🎉

@nodejs/security: can you perform a final review and approve this version?

cc: @ljharb @richardlau @tniessen @ShogunPanda @BethGriggs

ljharb

LGTM pending the remaining threads

UlisesGascon · 2023-08-05T21:26:55Z

In the last team meeting (see) we agreed to ask for a final review from the @nodejs/tsc.

In the meantime I will start working on #956 and prepare the discussions

RafaelGSS

ping @nodejs/tsc

UlisesGascon · 2023-08-21T08:01:46Z

Thanks a lot for all the hard work! ❤️

As agreed in our last meeting, I will merge this PR.

I hope to see the Silver badge soon 🙌

tniessen · 2023-08-21T10:29:51Z

tools/ossf_best_practices/silver_criteria.md

+The project repository front page and/or website MUST identify and hyperlink to any achievements, including this best practices badge, within 48 hours of public recognition that the achievement has been attained. (URL required) 
+
+**Met**


This appears to be missing the required URL.

Yes, good catch @tniessen. We have an issue open for it: nodejs/nodejs.org#5432 (comment). I hope that we can integrate it in the website 🤞

* feat: copied passing criterial Questions and Answers * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Ulises Gascón <UlisesGascon@users.noreply.github.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Ulises Gascón <UlisesGascon@users.noreply.github.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Ulises Gascón <UlisesGascon@users.noreply.github.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Ulises Gascón <UlisesGascon@users.noreply.github.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Ulises Gascón <UlisesGascon@users.noreply.github.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Ulises Gascón <UlisesGascon@users.noreply.github.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * Update tools/ossf_best_practices/silver_criteria.md Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com> * feat: update responses Ref: nodejs/security-wg#955 (comment) * feat: update responses ref: nodejs/security-wg#955 (comment) * feat: update responses ref: nodejs/security-wg#955 (comment) * feat: update responses ref: nodejs/security-wg#955 (comment) * feat: update responses ref: nodejs/security-wg#955 (comment) * feat: update responses ref: nodejs/security-wg#955 (comment) * feat: update responses ref: nodejs/security-wg#955 (comment) * Update tools/ossf_best_practices/silver_criteria.md * feat: update responses ref: nodejs/security-wg#955 (comment) * feat: update responses Ref: nodejs/security-wg#955 (comment) * feat: update responses Ref: nodejs/security-wg#955 (comment) * feat: update responses ref: nodejs/security-wg#955 (comment) * Update tools/ossf_best_practices/silver_criteria.md * feat: update responses Ref: nodejs/security-wg#955 (comment) * feat: update responses * feat: update responses * feat: update responses * Update tools/ossf_best_practices/silver_criteria.md * Update tools/ossf_best_practices/silver_criteria.md * feat: update responses ref: nodejs/security-wg#955 (comment) * feat: update responses ref: nodejs/security-wg#955 (comment) --------- Co-authored-by: Ulises Gascón <UlisesGascon@users.noreply.github.com> Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com>

feat: copied passing criterial Questions and Answers

2c7a9e8

This was referenced Apr 16, 2023

Initiative for CII-Best-Practices for Nodejs Projects #953

Open

CII-Best-Practices for Nodejs: Gold level #956

Closed

UlisesGascon marked this pull request as ready for review April 16, 2023 16:17

UlisesGascon commented Apr 16, 2023

View reviewed changes