doc(minutes): add 09 Feb 2026 #15
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,36 @@ | ||||||||||||
| # 09 February 2026 | ||||||||||||
|
|
||||||||||||
| ## Attendees | ||||||||||||
|
|
||||||||||||
| * Alex Vespa [@vespa7](https://github.com/vespa7) | ||||||||||||
| * Ethan Arrowood [@Ethan-Arrowood](https://github.com/Ethan-Arrowood) | ||||||||||||
| * Jacob Smith [@JakobJingleheimer](https://github.com/JakobJingleheimer) (chair) | ||||||||||||
| * Jordan Harband [@ljharb](https://github.com/ljharb) | ||||||||||||
| * Pietro Marchini [@pmarchini](https://github.com/pmarchini) | ||||||||||||
|
|
||||||||||||
| ## Topics | ||||||||||||
|
|
||||||||||||
| * `t.skip()` Others (tape, etc) to not behave like this. | ||||||||||||
| * standardising test runner design | ||||||||||||
| * https://github.com/WinterTC55/proposal-minimum-common-api/issues/32 | ||||||||||||
| * https://github.com/WinterTC55/proposal-minimum-common-api/issues/68 | ||||||||||||
| * [doc(proposal): `expectFailure` label and/or matcher](https://github.com/nodejs/test-runner/pull/10) | ||||||||||||
| * [doc(proposal): un/break `--test`](https://github.com/nodejs/test-runner/pull/13) | ||||||||||||
|
|
||||||||||||
| ## Outcomes | ||||||||||||
|
|
||||||||||||
| * General agreement that `t.skip()`'s behaviour is wrong (likely an accident/bug/mistake, which the docs seem to support). | ||||||||||||
|
Member
Author
There was a problem hiding this comment.
Suggested change
|
||||||||||||
| * General agreement that it would be good to standardise node's test-runner at the WinterTC55 level, if we can, but might be a very uphill battle. Perhaps better to audit our and others' design and adjust (and then take that to WinterTC). | ||||||||||||
| * https://github.com/nodejs/test-runner/pull/10 ready to approve | ||||||||||||
| * Un/break `--test` | ||||||||||||
| * option 3 | ||||||||||||
| * leave `--watch` as-is | ||||||||||||
| * in `test` mode, its value (`--watch` only enables watch mode) | ||||||||||||
| * support `--watch-path` in test mode | ||||||||||||
| * only `--test` N-times 1-to-1 with arg list, making it position-independent | ||||||||||||
|
|
||||||||||||
| ## Todos | ||||||||||||
|
|
||||||||||||
| * Decide if fixing `t.skip()` is a breaking change. | ||||||||||||
| * Jordan to find & share his audit of test runner features to use as base-point. | ||||||||||||
| * Jacob to incorporate "option 3" to https://github.com/nodejs/test-runner/pull/13 and tag team for review. | ||||||||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just checked the rest of the documentation, and the behavior is definitely intended:
https://nodejs.org/docs/v24.13.0/api/test.html#contextskipmessage.
When checking other test runners, like Mocha, this behavior also exists (e.g. https://mochajs.org/declaring/inclusive-tests/#_top).
Given that this behavior is "by design" and aligned with other test runners,IMHO , it's just a matter of personal preference...and I don't think it's enough to justify a major breaking change
P.S.: the same is true for Vitest as well (https://vitest.dev/guide/test-context.html#test-context)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, interesting. Thanks for checking!
If it's actually fairly common, then sure, it's already there. Kinda weird, but some people like liquorice too 🤷♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to understand how common it is, but I'm not sure that, without a standard, it makes sense to compare different tools...
cc @ljharb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If these runners all have the API, then that’s a very different story, but it still seems weird to me given the tap-like API the test runner has - which leads into the design philosophy discussion.