Skip to content

Conversation

@KhafraDev
Copy link
Member

fixes #4789

We end up with 1 less ReadableStream being created and fixes a few redirect-related issues with the body not being sent

Claude wrote a decent amount of the code, but I've gone through and picked through the 💩.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.26%. Comparing base (5a5920d) to head (6807da3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4791      +/-   ##
==========================================
+ Coverage   93.25%   93.26%   +0.01%     
==========================================
  Files         109      109              
  Lines       34024    34062      +38     
==========================================
+ Hits        31728    31768      +40     
+ Misses       2296     2294       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 9948d6f into nodejs:main Feb 1, 2026
36 of 37 checks passed
@github-actions github-actions bot mentioned this pull request Feb 1, 2026
@KhafraDev KhafraDev deleted the extract-body-fixes branch February 2, 2026 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error POST if body is instance of Buffer

3 participants