Support building only specific images & recipes for faster local dev#62
Open
ochafik wants to merge 1 commit intonodejs:mainfrom
Open
Support building only specific images & recipes for faster local dev#62ochafik wants to merge 1 commit intonodejs:mainfrom
ochafik wants to merge 1 commit intonodejs:mainfrom
Conversation
rvagg
reviewed
Nov 14, 2022
Comment on lines
+36
to
+38
| pre16 | ||
| compression | ||
| usdt |
Member
There was a problem hiding this comment.
Suggested change
| pre16 | |
| compression | |
| usdt | |
| armv6l-pre16 | |
| x64-pointer-compression | |
| x64-usdt |
was this changed intentionally? perhaps they need to be quoted when they're listed as an array?
rvagg
requested changes
Nov 14, 2022
Member
rvagg
left a comment
rvagg
left a comment
There was a problem hiding this comment.
pretty neat, but I think that one change is needed to make this still work properly in normal mode
Member
|
I'm proposing #108 as an alternative to this, it allows finer grained targeting of recipes and has some more flexibility than just overloading build.sh. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.