Skip to content

Conversation

@brannmark
Copy link

Implemented a safe filename function using regular expression.
The expression is reused from Umbraco default fileupload datatype.

Signed-off-by: brannmark anders@mirror.se

Implemented a safe filename function using regular expression.
The expression is reused from Umbraco default fileupload datatype.

Signed-off-by: brannmark <anders@mirror.se>
@nul800sebastiaan
Copy link

Thanks Anders! Your indentation settings are different, so it's a bit difficult to see the real changes, I'd prefer if you didn't reformat the code in the future. :-)
Question: did you really need to update the DLLs? I've been keeping the old version to make sure everything still builds and works on old installs of Umbraco.

@brannmark
Copy link
Author

Opps, on the indentation. :(

Really didnt need to update to dll's but I did so on my version for the project I'm using it on.

@brannmark
Copy link
Author

What type of changes do you want to see to add this?

@nul800sebastiaan
Copy link

Hmm, the project hasn't had my attention, sorry.. :)
Could you retry with the old dll's and no indentation changes?
This is Mikkel's package and I promised I'd be very careful with making changes, else I'd have accepted the pull request as it is.
Keep pestering me about this Anders, so I won't forget about it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants