Skip to content

Conversation

@WillNye
Copy link
Collaborator

@WillNye WillNye commented Nov 13, 2024

What changed?

  • Bumped python version to 3.11
  • Updated packages as needec
  • Replace the AWS account ids in the functional tests with a working orgs and accounts

Rationale

  • Explain the rationale behind this change and the approach.

How was it tested?

If it was manually verified, list the instructions for your reviewers to follow.

  • Unit Tests
  • Functional Tests
  • Manually Verified

@WillNye WillNye linked an issue Nov 13, 2024 that may be closed by this pull request
@CLAassistant
Copy link

CLAassistant commented Nov 13, 2024

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 83.87097% with 5 lines in your changes missing coverage. Please review.

Project coverage is 80.14%. Comparing base (348ba93) to head (a502b87).
Report is 22 commits behind head on main.

Files with missing lines Patch % Lines
iambic/main.py 0.00% 1 Missing ⚠️
iambic/plugins/v0_1_0/aws/iam/user/utils.py 0.00% 1 Missing ⚠️
...ntity_center/permission_set/template_generation.py 50.00% 1 Missing ⚠️
...v0_1_0/aws/identity_center/permission_set/utils.py 0.00% 1 Missing ⚠️
iambic/plugins/v0_1_0/github/github.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #683      +/-   ##
==========================================
+ Coverage   72.52%   80.14%   +7.62%     
==========================================
  Files         108      108              
  Lines       12966    12995      +29     
==========================================
+ Hits         9403    10415    +1012     
+ Misses       3563     2580     -983     
Flag Coverage Δ
functional_tests 55.23% <58.06%> (?)
functional_tests_config_discovery 40.96% <45.16%> (?)
unit_tests 72.28% <64.51%> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WillNye
Copy link
Collaborator Author

WillNye commented Nov 24, 2024

Been busy but slow progress is being made

@WillNye WillNye marked this pull request as ready for review November 27, 2024 01:23
@WillNye WillNye requested review from castrapel and smoy November 27, 2024 01:24
Copy link
Contributor

@castrapel castrapel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WillNye WillNye merged commit a707d1b into main Nov 27, 2024
4 checks passed
@WillNye WillNye deleted the 682-bump-python-version-to-313-and-update-out-of-date-poetry-packages branch November 27, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bump python version to 3.11 and update out of date poetry packages

4 participants