Skip to content

Fix parallax and particles in sections#8

Open
EdenK wants to merge 1 commit intonorewp:masterfrom
EdenK:master
Open

Fix parallax and particles in sections#8
EdenK wants to merge 1 commit intonorewp:masterfrom
EdenK:master

Conversation

@EdenK
Copy link

@EdenK EdenK commented Jul 12, 2018

Changed the hooks

elementor/frontend/element/before_render
elementor/frontend/element/after_render

to:

elementor/frontend/section/before_render
elementor/frontend/section/after_render

@dthomas3349
Copy link

please pardon my ignorance considering changing the Hooks and where that is to be done. I would like to update back to the latest elementor however, I looked in the WP plug-in editor but I didn't see those two lines of copy.I'm afraid I wouldn't know how to change the two lines of code and were to do it. Is there another plug-in that has the same effects?

@EdenK
Copy link
Author

EdenK commented Jul 14, 2018

@dthomas3349 You can see the files that changed in the file changed tab https://github.com/norewp/granular-controls-elementor/pull/8/files

Or you can download my fork to the plugin with the changes from here
https://github.com/EdenK/granular-controls-elementor

@dthomas3349
Copy link

dthomas3349 commented Jul 14, 2018 via email

@EdenK
Copy link
Author

EdenK commented Jul 14, 2018

@dthomas3349 Yes you can download the zip file and you can install it as plugin from the dashboard or you can replace only the files that changed in the plugin directory thats in your server.

If you install the plugin from the dashboard you will need to disable the other version of the plugin they will be with the same name so you need to make sure which is whice before you activate or deactivate them.

Probably the easy just to replace the 2 files that I changed in the plugin directory via ftp.

This 2 files:
modules/granular-parallax/module.php
modules/granular-particles/module.php

You can update the elementor before or after its doesn't matter.

@dthomas3349
Copy link

dthomas3349 commented Jul 14, 2018 via email

@EdenK
Copy link
Author

EdenK commented Jul 14, 2018

@dthomas3349 I see what you mean it was a z-index issue. I fixed it right now so if you download my fork again it will be ok.

Its the same 2 files thats need to be changed.

@prim4t
Copy link

prim4t commented Jul 28, 2018

Guys i just wanted to say thank you for your efford!
I randomly found your solution and you helped me out alot!

Greetings
PRIM4T

@shanewarner
Copy link

Confirmed this fixed my site. Thanks a lot man!

@Jampott
Copy link

Jampott commented May 19, 2020

Great help this, thanks, I do have a little problem though...

With the parallax, the positioning of the image seems a bit off. If set up in edit to display at top middle, bottom or custom, when the page displays it always seems to be at the top of the image, which is a bit of a pain as I need to edit the image to remove excess sky etc.

If anyone out there is listening...... ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants