Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary:
assertis used inkdtree_cpu.cppbut<cassert>is not included directly.It seems to be included through Eigen/Core, but this does not appear to be the case in the latest file, which causes the build to fail.
Changes and type of changes (quick overview):
<cassert>Checklist:
Code related
(i.e.: function, class, script header, README.md)
(Check contributing/contributing_instructions.md for local testing procedure using libnabo-build-system)
PR creation related
base refbranch is set to thedevelopbranch(the build-system won't be triggered otherwise)
developbranch(the build-system will reject it otherwise)
PR description related
# <issue-id>if changes are of typefix(See contributing/commit_msg_reference.md for details)