-
Notifications
You must be signed in to change notification settings - Fork 25
Updated pom.xml by Safer #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
See details in issue #138 |
WalkthroughThe Changes
Possibly related issues
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
pom.xml (1)
178-181: Consider using OkHttp BOM to keep all 4.12.0 modules aligned & avoid duplicationYou currently:
- Declare
logging-interceptor,mockwebserverandokhttpall at 4.12.0.- Exclude
okhttpfrommockwebserverand re-add it explicitly.Square provides a BOM (
com.squareup.okhttp3:okhttp-bom) that keeps every module on the same version and removes the need for manual exclusions:+ <!-- Centralise OkHttp versions --> + <dependencyManagement> + <dependencies> + <dependency> + <groupId>com.squareup.okhttp3</groupId> + <artifactId>okhttp-bom</artifactId> + <version>4.12.0</version> + <type>pom</type> + <scope>import</scope> + </dependency> + </dependencies> + </dependencyManagement>Then all OkHttp artefacts can omit
<version>and you can drop the explicit exclusion stanza. Keeps future updates safer and tidier.Also applies to: 206-221
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
pom.xml(3 hunks)
🔇 Additional comments (1)
pom.xml (1)
168-176: Retrofit 3.0.0 is available on Maven Central – no changes needed
A query against Maven Central’s public API returnednumFound=1forcom.squareup.retrofit2:retrofit:3.0.0, so the 3.0.0 artifacts (includingconverter-gson) are published and the build will succeed as-is.Likely an incorrect or invalid review comment.
This PR was automatically created by Safer, an open-source tool that updates vulnerable dependencies with compatible and more secure versions.
Analyzed commit: c36eebc
File updated: pom.xml
Vulnerabilities reduced: 7 -> 0
Let us know if you have questions.
Thanks,
Safer Bot
Summary by CodeRabbit