-
Notifications
You must be signed in to change notification settings - Fork 1.4k
manifest: sdk-hostap: Pull assert check for HEAP #10287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
ce8fa78 to
18124bc
Compare
|
With recent influx of changes the RAM usage is at peak, so, we have made changes to samples to decrease |
|
I get a build warning in the MQTT sample for this manifest update: I peaked a bit into sdk-hostap and saw that the log buffer is redefined in there. Shouldn't it be up to the application/sample to set this buffer depending on the modules it includes. If the sample uses immediate logging its not used either AFAIK. |
|
That's just the default, sample can overwrite that, let me check why it is warning? |
|
CI failures are being fixed by #10304 |
@krish2718 the Matter PR is now merged, you can rebase your branch. |
18124bc to
721537a
Compare
Its a warning because its set in the board config overlay file. Since the default is higher with these changes I think it can be removed from the |
And now the CI is failing due to too big code size (FLASH overflow). |
Thanks. This again seems to be Matter tests @markaj-nordic can you please check, Matter is OOM again? |
I guess we cannot force the applications to select the ASSERT_VERBOSE or DEBUG. This needs to be relaxed (i.e. by using |
This enables the assert for minimum libc HEAP and fails boot, saves us time from hard to debug issues due to low HEAP. Signed-off-by: Krishna T <krishna.t@nordicsemi.no>
721537a to
14b6140
Compare
|
The CI is still failing even with
|
I am wondering if it makes any sens to do it the other way around, i.e. having at least the |
|
I would also recommend to set Btw. I would pull inside |
|
ok, dropped 2.3.0 milestone and also raised a revert PR for hostapd, let me revisit this. |
This enables the assert for minimum libc HEAP and fails boot, saves us time from hard to debug issues due to low HEAP.