Skip to content

Conversation

@degjorva
Copy link
Contributor

@degjorva degjorva commented Dec 8, 2025

Add ENTROPY_GENERATOR=y in overlay
This fixes an error where a trng source is not included in ncs. Addition of this for other L series devices is also a noup.

Add ENTROPY_GENERATOR=y in overlay
This fixes an error where a trng source is not included in ncs.
Addition of this for other L series devices is also a noup.

Signed-off-by: Dag Erik Gjørvad <dag.erik.gjorvad@nordicsemi.no>
NordicBuilder added a commit to NordicBuilder/sdk-nrf that referenced this pull request Dec 8, 2025
Automatically created by action-manifest-pr GH action from PR:
nrfconnect/sdk-zephyr#3616

Signed-off-by: Nordic Builder <pylon@nordicsemi.no>
@degjorva degjorva requested a review from a team December 8, 2025 15:26
@nordic-piks
Copy link
Contributor

You can avoid noup by adding test here: https://github.com/nrfconnect/sdk-nrf/tree/main/tests/zephyr
ie. reference original code and settings, specify custom sample.yaml for ls05 and board overlay.
Then, original zephyr test will stay in quarantine (until upmerging ls05 board).

@degjorva
Copy link
Contributor Author

degjorva commented Dec 9, 2025

@nordic-piks This entire config is a noup though, not just for ls05, but for all 54L boards. Or can I do that for all of these boards?

@nordic-piks
Copy link
Contributor

@nordic-piks This entire config is a noup though, not just for ls05, but for all 54L boards. Or can I do that for all of these boards?

You can make nrf.extended test for any platform. Up to you. Just adding new overlay as noup is probably no a big problem during upmerge.

Copy link
Contributor

@tomi-font tomi-font left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this a fixup commit (@Vge0rge does it) so it gets squashed together with the original noup when a history cleanup is made?

@Vge0rge
Copy link
Contributor

Vge0rge commented Dec 11, 2025

Make this a fixup commit (@Vge0rge does it) so it gets squashed together with the original noup when a history cleanup is made?

You mean the nrf-quash tag. Indeed it is a good idea to have this here.
The format is simple:

[nrf noup] You commit here
<empty line>
nrf-squash! [nrf noup]  the original noup commit title
<empty line>
Your description here

@degjorva
Copy link
Contributor Author

degjorva commented Dec 19, 2025

@piotrkoziar I could not get it to work using your setup, as when adding it to sdk-nrf we also include PSA_CRYPTO_PROVIDER_CUSTOM when trying to run with this. Which breaks the build. I created a draft here: nrfconnect/sdk-nrf#26373 which uses your way to exclude 54L series devices from these tests. As it is not a supported use case I think this makes the most sense. Is that an acceptable solution for you?

If it is I will open a revert pr the noups for all 54L series devices and close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants