-
Notifications
You must be signed in to change notification settings - Fork 743
[nrf noup] tests: crypto: Add overlay for new board #3616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Add ENTROPY_GENERATOR=y in overlay This fixes an error where a trng source is not included in ncs. Addition of this for other L series devices is also a noup. Signed-off-by: Dag Erik Gjørvad <dag.erik.gjorvad@nordicsemi.no>
Automatically created by action-manifest-pr GH action from PR: nrfconnect/sdk-zephyr#3616 Signed-off-by: Nordic Builder <pylon@nordicsemi.no>
|
You can avoid noup by adding test here: https://github.com/nrfconnect/sdk-nrf/tree/main/tests/zephyr |
|
@nordic-piks This entire config is a noup though, not just for ls05, but for all 54L boards. Or can I do that for all of these boards? |
You can make nrf.extended test for any platform. Up to you. Just adding new overlay as noup is probably no a big problem during upmerge. |
tomi-font
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make this a fixup commit (@Vge0rge does it) so it gets squashed together with the original noup when a history cleanup is made?
You mean the nrf-quash tag. Indeed it is a good idea to have this here. |
|
@piotrkoziar I could not get it to work using your setup, as when adding it to sdk-nrf we also include PSA_CRYPTO_PROVIDER_CUSTOM when trying to run with this. Which breaks the build. I created a draft here: nrfconnect/sdk-nrf#26373 which uses your way to exclude 54L series devices from these tests. As it is not a supported use case I think this makes the most sense. Is that an acceptable solution for you? If it is I will open a revert pr the noups for all 54L series devices and close this PR. |
Add ENTROPY_GENERATOR=y in overlay
This fixes an error where a trng source is not included in ncs. Addition of this for other L series devices is also a noup.