Conversation
ZaynJarvis
left a comment
ZaynJarvis
left a comment
There was a problem hiding this comment.
Nice feature!
One of the implementations can be Windows-specific.
| @@ -1,18 +1,45 @@ | |||
| import React from 'react'; | |||
| import PropTypes from 'prop-types'; | |||
| import * as PropTypes from 'prop-types'; | |||
There was a problem hiding this comment.
Why we are doing this? isn't PropTypes directly good enough?
There was a problem hiding this comment.
As PropTypes is no longer the default export name, we use * and change the name to PropTypes for better ide support
| text-decoration: none; | ||
| } | ||
| /* only apply in webkit */ | ||
| @media screen and (-webkit-min-device-pixel-ratio:0) { |
There was a problem hiding this comment.
It will be good if the scroll bar changes only apply to Windows users. Since mac has a built-in feature to hide scroll bar when no action performed.
refer here
There was a problem hiding this comment.
marked. Will do later
| <html lang="en"> | ||
| <head> | ||
| <meta charset="utf-8" /> | ||
| <!--suppress HtmlUnknownTarget --> |
There was a problem hiding this comment.
suppress ide warning check
There was a problem hiding this comment.
Would it be possible to set this up in a config file which can be ignored by .gitignore?
There was a problem hiding this comment.
I don't feel so. This is autogenerated by IDEA
There was a problem hiding this comment.
then one of the approaches may put this file into .gitignore.
It will be confusing to have a ide specific feature implemented in the code other than configuration files
| transition: color .8s; | ||
| } | ||
| .iceberx-app-container:hover { | ||
| color: rgba(0,0,0,0.3); |
There was a problem hiding this comment.
It seems when hover on the window the hover will take effect in Mac.
There was a problem hiding this comment.
Yep. This is some tricky part. Scrollbar itself does not have the transition effect. Check here.
There was a problem hiding this comment.
It's okay for now. If no better solution, the implementation is good enough. Just try to make it Windows specific.
|
Also, There's an increase in colour grey scale in Buttons, not sure if this is a preview defect. |
2 participants
No description provided.