Get channel id from channel url #447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@justinhoward Would you review this pr |
justinhoward
approved these changes
Sep 16, 2025
|
|
||
| def get_request(params = {}) | ||
| @list_request = Yt::Request.new(params).tap do |request| | ||
| @get_request = Yt::Request.new(params).tap do |request| |
Member
There was a problem hiding this comment.
Nit: This assignment serves no purpose right?
Contributor
Author
There was a problem hiding this comment.
Yes you are right, the @get_request is not used anywhere. We need to raise an error using it in the message, when request failed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.