Skip to content

Conversation

@AnassHmida
Copy link
Contributor

This commit updates the build.gradle file to dynamically determine ABI filters
based on project requirements. Instead of relying on static ABI configurations,
the reactNativeArchitectures() function is introduced to fetch ABI filters from
project properties or default to a standard set when not specified. This ensures
that only the necessary ABIs are processed during the build, addressing issues
related to incorrect ABI configurations.

Changes include:

  • Introduced reactNativeArchitectures() function to fetch ABI filters dynamically.
  • Updated cmake block in build.gradle to use abiFilters (*reactNativeArchitectures()).

This resolves issues where CMake attempted to build unnecessary ABIs, improving
build efficiency and reliability.

To test this change:

  1. Ensure your development environment has React Native dependencies installed and configured.
  2. Run the project build with various Android ABIs (e.g., armeabi-v7a, arm64-v8a, x86, x86_64) using different build configurations (debug and release).
  3. Verify that the build process completes successfully without attempting to build unsupported architectures and that the correct ABI is selected based on the project's configuration. Pay special attention to scenarios involving --active-arch to ensure correct ABI detection.

@JerakRus
Copy link

@numandev1
Hi, considering the upcoming changes in Android - this request seems mandatory. Could you please consider it? Otherwise many will have to abandon your library. https://android-developers.googleblog.com/2025/05/prepare-play-apps-for-devices-with-16kb-page-size.html?m=1

There is also a discussion in mmkv: Tencent/MMKV#1517

@ngocle2497 ngocle2497 merged commit f6b29bc into numandev1:main Jul 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants