This repository was archived by the owner on Nov 10, 2025. It is now read-only.
Open
Conversation
bveeramani
suggested changes
Mar 11, 2022
Member
bveeramani
left a comment
bveeramani
left a comment
There was a problem hiding this comment.
LGTM. Left a minor comment
| import nums.core.settings as settings | ||
|
|
||
| if backend is not None: | ||
| assert backend in {"serial", "ray", "dask", "mpi"} |
Member
There was a problem hiding this comment.
We should raise a ValueError instead of an AssertionError. From the Google style guide:
Do not use assert statements for validating argument values of a public API. assert is used to ensure internal correctness, not to enforce correct usage nor to indicate that some unexpected event occurred.
(We use Black, but this is still applicable)
Member
There was a problem hiding this comment.
We should also include a descriptive error message if the users inputs an incorrect value. e.g., f"Expected backend to be one of {BACKEND_NAMES}, but got {backend}."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.