Skip to content

Add cancel after snippets#1114

Merged
SeanKilleen merged 2 commits intonunit:masterfrom
stevenaw:cancel-after-docs
Dec 7, 2025
Merged

Add cancel after snippets#1114
SeanKilleen merged 2 commits intonunit:masterfrom
stevenaw:cancel-after-docs

Conversation

@stevenaw
Copy link
Member

@stevenaw stevenaw commented Dec 7, 2025

Relates to #1095

Updates some documentation for CancelAfter by moving some examples to snippets and adding a TestCaseSource-oriented snippet as well

@stevenaw stevenaw changed the title Add cancel after snippets WIP: Add cancel after snippets Dec 7, 2025
@stevenaw stevenaw changed the title WIP: Add cancel after snippets Add cancel after snippets Dec 7, 2025
@stevenaw stevenaw marked this pull request as ready for review December 7, 2025 19:45
@stevenaw
Copy link
Member Author

stevenaw commented Dec 7, 2025

Switching this back to a draft. It seems I didn't commit some final changes in codespaces properly

@stevenaw stevenaw marked this pull request as draft December 7, 2025 19:47
@stevenaw stevenaw marked this pull request as ready for review December 7, 2025 20:08
@stevenaw
Copy link
Member Author

stevenaw commented Dec 7, 2025

I think this is ready now.

Copy link
Member

@SeanKilleen SeanKilleen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@SeanKilleen SeanKilleen merged commit ab1e1d6 into nunit:master Dec 7, 2025
7 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 7, 2025
* Add cancel after snippets

* Adjust some formatting for cancelafter attribute ab1e1d6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants