Draft
Conversation
This removes our next.js dependency from the dashboard, and instead replaces it with an (opt-in for now), option to run the dashboard as a SPA, which is backed by a light weight backend.
jonmorehouse
force-pushed
the
remove-next-js
branch
from
4de5a8a to
1772b54
Compare
|
This PR was marked as stale, and will be closed after 3 more days. Add the #keep-open label to prevent this from being closed. |
This removes our next.js dependency from the dashboard, and instead replaces it with an (opt-in for now), option to run the dashboard as a SPA, which is backed by a light weight backend.
jonmorehouse
force-pushed
the
remove-next-js
branch
from
1bd2b21 to
7e1a14b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of our longer term plan is to remove the dashboard-ui's dependency on next.js. There's a few problems we've seen
with it, and we just are not using it's full functionality (nor do we plan too).
This PR creates an optional, SPA mode that uses vite to build the assets and serves the dashboard via a simple golang
backend. This enables a backend-for-frontend approach, where we can replace much of our SSR and other next.js features
with specialized endpoints that use our go SDK.
Right now, the design is that this is something we can run alongside our current dashboard, and flip it over with
env-vars to control how this is loaded. This prevents us from having to have an "all at once" switch over.
@nnnnat, this PR is still early, but I'm opening it so we can both 👀 it and gather feedback as we go.