fix(frontend): origin address info leak #2709
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, frontend loads device images from third-party domain https://www.zigbee2mqtt.io/, leaking potentially sensitive information, as the address might be externally routable IPv6 address, etc. We need to remove crossorigin="anonymous" to stop sending Origin header, and add referer="no-referer" referrer policy to stop sending Origin header. Note that as <image> elements don't support refererpolicy attribute, we have to add document-wide policy. Which is a good idea, as it also prevents leaks when following links.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Author
|
Bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, frontend loads device images from third-party domain https://www.zigbee2mqtt.io/, leaking potentially sensitive information, as the address might be externally routable IPv6 address, etc.
We need to remove
crossorigin="anonymous"to stop sending Origin header, and addreferer="no-referer"referrer policy to stop sending Origin header. Note that as<image>elements don't support refererpolicy attribute, we have to add document-wide policy. Which is a good idea, as it also prevents leaks when following links.Fixes #2708