-
Notifications
You must be signed in to change notification settings - Fork 25
Update to windows-sys 0.60 #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
What would this bump our MSRV to? We currently support 1.62.1. |
|
No change in Rust version. 0.60.2 has an MSRV of 1.60. |
|
When I try to build this PR with the nu-ansi-term MSRV 1.62.1 I get errors. |
Good catch: I forgot that |
be4bf23 to
9415e7f
Compare
|
Thanks |
#66 updated the `windows-sys` dependency to `0.60.0` to allow for ARM64EC support, but ARM64EC support was originally introduced in `0.59.0`. Since both `windows-sys` and `nu-ansi-term` are both widely used, it's good to have a larger dependency range to avoid duplicate dependencies in user's buildgraphs (and triggering `clippy::multiple-crate-versions`). There's precedent for doing this in many crates: * https://lib.rs/crates/windows-sys/rev * https://lib.rs/crates/windows/rev
|
It seems like a new rust version maybe is required. I'm not sure if we want to bump to 1.71 /cc @cptpiepmatz Update: oh wait, maybe windows-sys should be 0.60 vs 0.61? |
Yep, windows-sys 0.61 requires Rust 1.71 because it uses the |

I'd like to move all dependency of Cargo to the latest
windows-syssince older versions don't support Arm64EC.