Skip to content

Add sonar cloud analysis #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
ignacio-penas wants to merge 24 commits into
base: main
Choose a base branch
from
Draft

Add sonar cloud analysis #344

ignacio-penas wants to merge 24 commits into from

Conversation

@ignacio-penas
Copy link
Contributor

@ignacio-penas ignacio-penas commented Feb 26, 2024 •
edited
Loading

I have separated the dev build and the unittests into two different workflows for two main reasons.

  • To have the unittests and sonar scan run in pushes against any branch. I haven't found a clean way of executing only one of the two when there is a PR opened and a push is done against the branch.
  • So the dev image is only built when the PR is opened.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 26, 2024 •
edited
Loading

Test Results

34 tests  ±0   34 ✅ ±0   2s ⏱️ -1s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit fbc9108. ± Comparison against base commit b03fb68.

♻️ This comment has been updated with latest results.

Nacho added 21 commits February 26, 2024 15:44
Fix sonar-project.properties file v1
87d0871
Make sonar verbose
08b1a2b
fix: update sonar cloud token name
5487b40
add dockerfile scan to workflow
e34ae43
add fixed python version to sonar
d868949
fix sonarscan version
a8b6546
fix hadolint action version
47eac57
hadolint shouldnt fail
1a4d582
add branch coverage
19a7eb2
Split dev. build and tests. Remove tox, use poetry to handle envs
f705901
Fix dev-build workflow
58174bd
Update lock file
dc1625d
Add tox to handle test virtual env
f63e581
Add quality gate check
479c9ee
Test coverage check
656f971
Add concurrency check
052c390
Allow PR and commit trigger the unittests.yml workflow in parallel. D…
19e559e 
…ev build trigger only on PR
Dev build trigger only on PR
a7e897e
Allow unittests.yml to cancel same triggered workflow
1e070ef
Fix build status badge
a8cbb4f
Trigger dev build and unittests on file modifications
1919900
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ignacio-penas ignacio-penas requested a review from konstan March 5, 2024 15:53
@ignacio-penas
Merge branch 'main' into add-sonar-analysis
5cf451c 
# Conflicts:
#	README.md
#	poetry.lock
#	pyproject.toml
@ignacio-penas
update lock
fbc9108
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 8, 2024 •
edited
Loading

Quality Gate Failed Quality Gate failed

Failed conditions
35.6% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@schaubl schaubl marked this pull request as draft May 8, 2024 13:59
@schaubl
Copy link
Contributor

schaubl commented May 8, 2024

Pending: waiting code coverage

@schaubl schaubl force-pushed the main branch 3 times, most recently from b230b74 to d406034 Compare April 16, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@konstan konstan Awaiting requested review from konstan

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ignacio-penas @schaubl