Skip to content

Restore possibility to add '--ignore' flag #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
d3ph wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Restore possibility to add '--ignore' flag #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
033cb7f
Restore possibility to add '--ignore' flag
d3ph Apr 19, 2016
069d2ca
remove 'ignore' from deprecated list
d3ph Apr 19, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion README.mdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,6 @@ advise users to use the `~/.config/flake8` config file.

- Decprecated options:
- `g:flake8_builtins`
- `g:flake8_ignore`
- `g:flake8_max_line_length`
- `g:flake8_max_complexity`

Expand Down
6 changes: 4 additions & 2 deletions autoload/flake8.vim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ function s:Warnings()
let l:show_website_url = 0

let l:msg = "has been deprecated in favour of flake8 config files"
for setting_name in ['g:flake8_ignore', 'g:flake8_builtins', 'g:flake8_max_line_length', 'g:flake8_max_complexity']
for setting_name in ['g:flake8_builtins', 'g:flake8_max_line_length', 'g:flake8_max_complexity']
if exists(setting_name)
echohl WarningMsg | echom setting_name l:msg | echohl None
let l:show_website_url = 1
Expand Down Expand Up @@ -71,6 +71,8 @@ function! s:Setup() " {{{

" flake8 command
call s:DeclareOption('flake8_cmd', '', '"flake8"')
" ignore
call s:DeclareOption('flake8_ignore', ' --ignore=', '')
" quickfix
call s:DeclareOption('flake8_quickfix_location', '', '"belowright"')
call s:DeclareOption('flake8_quickfix_height', '', 5)
Expand Down Expand Up @@ -137,7 +139,7 @@ function! s:Flake8() " {{{

" perform the grep itself
let &grepformat="%f:%l:%c: %m\,%f:%l: %m"
let &grepprg=s:flake8_cmd
let &grepprg=s:flake8_cmd.s:flake8_ignore
silent! grep! "%"

" restore grep settings
Expand Down