Using archiver.bulk & graceful-ncp over ncp to avoid EMFILE errors

[adam-lynch]

@steffenmllr, I'll leave this for you to merge

Thanks, @felixSchl.

Closes #92, #118

[adam-lynch]

Oh wait, hold off... I just saw this in the package.json:

"fs-extra": "git://github.com/adam-lynch/node-fs-extra#graceful-ncp",

[adam-lynch]

Ok, I've created a PR; jprichardson/node-fs-extra#95. We could wait until it's merged or else just merge and then change it back to using node-fs-extra from npm once it is merged.

[adam-lynch]

@felixSchl One of the tests were actually failing (see https://travis-ci.org/mllrsohn/node-webkit-builder/jobs/41839735#L245) but it wasn't failing the build because of #126.

The issue was with archive.bulk. The test is now passing with my changes in b69eca8. Could you have another look and make sure everything is ok?

[steffenmllr]

@adam-lynch You know the codebase better than me at this point :) so feel free to merge this when you think it's right - I would however wait for the fs-extra thing to be merged.

I have to check why we even need fs-extra ...

[adam-lynch]

@steffenmllr I think I'm going to go ahead and merge this later. We could be waiting forever on other people and it'll be a big benefit to merge (along with 64-bit support for 1.0.0).

Instead of waiting on a PR, I can create another npm package which just makes sure node-fs-extra uses graceful-ncp instead of ncp. It's only a one line package and would be better than having a github branch as a dependency since it'll only be updated when node-fs-extra publish a new release, not whenever they commit to master.

When the time comes, I'll switch the dependency to node-fs-extra instead if they merge my PR or if ncp merges my PR (AvianFlu/ncp#70), then I'll just close my node-fs-extra PR and revert our dependency to ncp instead of my graceful-ncp. Nothing much to worry about because my changes to all packages concerned are tiny, no real maintenance involved

Long story short, I'll probably just merge this and it'll be fine 😄.

[adam-lynch]

Thanks a lot @felixSchl. I'd appreciate if you could test master (npm i -D mllrsohn/node-webkit-builder) before I release 1.0.0. I seem to getting an EMFILE error even with these changes 😢

[adam-lynch]

Nevermind what I said about the EMFILE error, it was just a typo in my stubbing of ncp in graceful-fs-extra.