Prettify

[o-murphy]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @o-murphy, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the project's maintainability and developer experience by standardizing code style and modernizing the build process. It integrates automated tools for linting and formatting, updates core dependencies, and refines various code sections for improved consistency and clarity. The changes aim to streamline development workflows and ensure a higher quality codebase going forward.

Highlights

• Code Formatting and Linting: Introduced pre-commit hooks via .pre-commit-config.yaml to automate code formatting with ruff format and linting with ruff check --fix, ensuring consistent code style across the project.
• Build System Modernization: Updated pyproject.toml to use setuptools-scm for dynamic versioning, removing the hardcoded version, and added development dependencies for mypy and pre-commit.
• Dependency Updates: Updated setuptools and pyserial requirements in pyproject.toml to newer versions and added importlib-metadata for compatibility with older Python versions.
• File Inclusion and Exclusion: Expanded the .gitignore file to include more common Python build artifacts, virtual environment directories, and IDE-specific files, and added LICENSE.md and README.md to Manifest.in for package distribution.
• Codebase Refinements: Applied extensive formatting changes, consistent string literal usage (double quotes), and minor refactorings across ymodem/CRC.py, ymodem/Platform.py, ymodem/Protocol.py, ymodem/Socket.py, and ymodem/Version.py for improved readability and maintainability.
• Dynamic Versioning: Implemented dynamic versioning for the package by adding __version__ in ymodem/__init__.py using importlib.metadata and integrated it into the CLI tool in ymodem/__main__.py.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files

• Ignored by pattern: .github/workflows/** (1)
  • .github/workflows/python-publish.yml

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces significant improvements by adding modern development tools like pre-commit with ruff, updating the project configuration, and applying consistent code formatting. These are great steps towards better code quality and maintainability. My review includes a few suggestions to further enhance the code, including fixes for two critical bugs in the version parsing and comparison logic, removal of some redundant code, and corrections to type hints.