This repository was archived by the owner on Mar 11, 2019. It is now read-only.
Open
Conversation
Owner
|
Looks pretty good! Thanks for working on this. Are you planning on adding more? |
Author
|
np, thanks for play-clj :) Sure I'll finish off the public methods in core for this PR and then hopefully go namespace by namespace. |
Author
|
Okay think this is ready to merge! Tested the tutorial game with instrumentation on and had no problems. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looking to get the ball rolling here. Let me know what you think, will be looking to refine the specs further in the future, for example some are only doing basic map? checks at the moment.