This repository was archived by the owner on Jan 19, 2022. It is now read-only.
Open
Conversation
Conflicts: lib/descartes/routes/metrics.rb
Real webapp behavior has non-empty params.
Conflicts: lib/descartes/public/js/list-metrics.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #73.
Dug into this to start addressing my problems w/ metric loads in my prod environment, which has something like 800k distinct metric paths and growing.
Right now, with the "load all metrics on start" behavior, I suck down 80MB of metric path data, which kinda sucks when talking to a non-local-to-workstation server:
With pagination enabled & the app set to default to 1 page at a time, it's a much more reasonable 4KB:
This implementation doesn't appear to affect search results (and no attempt was made to paginate them from the backend, as they're typically much smaller, & I will have another PR soon for making the search itself faster anyways.)