This repository was archived by the owner on Jan 19, 2022. It is now read-only.
Open
Conversation
|
You don't need team support but it's pretty easy to enable it. Check for a team id in the environment and fall back to an organization otherwise. The deprecation warnings are related to key changes in the github_options has you set in the sinatra app. |
|
It looks like this is a bug in the sinatra_auth_github gem? https://github.com/atmos/sinatra_auth_github/blob/master/lib/sinatra/auth/github.rb#L156 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need to update our GitHub OAuth code to support the newest stuff in https://github.com/atmos/sinatra_auth_github. I've bumped the gem to 0.13.3 but I think there's some configuration stuff and possibly scopes changes that we need to consider.
I know that @atmos has pointed me in the right direction wrt Teams authentication but I'm an idiot when it comes to OAuth. I'm not sure whether we need to support Teams for everyone, just for internal GH use, or what. @brntbeer - you're the project guru when it comes to this, do you mind taking a look at this?
P.S. Here is some logging output from this branch. Note the deprecation warnings.