When warning and critical thresholds are equal, don't go critical on stats that are less than the critical threshold. #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stats that are less than the critical threshold.
Owner
|
Why don't you just set |
Author
|
Doesn't line 95 make a 0, which is what we want under normal operation, a warning? I'd rather not have a warning if there isn't an actual warning. |
Owner
|
Sure, but you're also using the check in a way it isn't meant to be used. What happens if warning == critical where 1 is "good" and 0 is "bad"? (theoretical scenario another user might have) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a dead letter queue that we want to be alerted on if any message is sent there. Setting warning/critical both to 1 caused a 0 from graphite to go critical in nagios.