-
Notifications
You must be signed in to change notification settings - Fork 0
Fix TransactionManager type mismatch and ConditionalAuthWrapper import paths #428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…nditionalAuthWrapper import paths Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Fixes CI failures by aligning TransactionManager’s action executor type with the enhanced UI action schema, and by correcting broken relative imports in the console’s conditional auth wrapper.
Changes:
- Update
TransactionManager.executeTransaction()to acceptUIActionSchema(enhanced action schema) instead of legacy CRUDActionSchema. - Fix
ConditionalAuthWrapperrelative import paths forObjectStackAdapterandLoadingScreen.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/core/src/actions/TransactionManager.ts | Uses UIActionSchema for actionExecutor to match TransactionConfig.actions and resolve the TS2345 build error. |
| apps/console/src/components/ConditionalAuthWrapper.tsx | Corrects relative imports to match the file’s actual location under components/, resolving console test failures. |
📦 Bundle Size Report
Size Limits
|
All three CI jobs (Test, Build Core, Build Docs) fail due to a type error in
@object-ui/corebuild, and two console tests fail due to broken imports.Build error:
TransactionManager.ts(TS2345)TransactionConfig.actionsis typed asActionSchema[]fromui-action.ts, but theactionExecutorcallback parameter used the legacyActionSchemafromcrud.ts. These are incompatible (type: ActionTypevstype: 'action').Test failures:
ConditionalAuthWrapper.tsxTwo wrong relative imports — the file is in
components/but referenced paths as if it were insrc/:'./dataSource'→'../dataSource''./components/LoadingScreen'→'./LoadingScreen'💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.