Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Feb 10, 2026

All three CI jobs (Test, Build Core, Build Docs) fail due to a type error in @object-ui/core build, and two console tests fail due to broken imports.

Build error: TransactionManager.ts (TS2345)

TransactionConfig.actions is typed as ActionSchema[] from ui-action.ts, but the actionExecutor callback parameter used the legacy ActionSchema from crud.ts. These are incompatible (type: ActionType vs type: 'action').

-import type { ..., ActionSchema } from '@object-ui/types';
+import type { ..., UIActionSchema } from '@object-ui/types';

-actionExecutor: (action: ActionSchema) => Promise<ActionResult>,
+actionExecutor: (action: UIActionSchema) => Promise<ActionResult>,

Test failures: ConditionalAuthWrapper.tsx

Two wrong relative imports — the file is in components/ but referenced paths as if it were in src/:

  • './dataSource''../dataSource'
  • './components/LoadingScreen''./LoadingScreen'

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@vercel
Copy link

vercel bot commented Feb 10, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
objectui Error Error Feb 10, 2026 9:40am
objectui-console Ready Ready Preview, Comment Feb 10, 2026 9:40am
objectui-storybook Ready Ready Preview, Comment Feb 10, 2026 9:40am

Request Review

…nditionalAuthWrapper import paths

Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix all CI build and test errors Fix TransactionManager type mismatch and ConditionalAuthWrapper import paths Feb 10, 2026
Copilot AI requested a review from hotlong February 10, 2026 09:35
@hotlong hotlong marked this pull request as ready for review February 10, 2026 09:37
Copilot AI review requested due to automatic review settings February 10, 2026 09:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes CI failures by aligning TransactionManager’s action executor type with the enhanced UI action schema, and by correcting broken relative imports in the console’s conditional auth wrapper.

Changes:

  • Update TransactionManager.executeTransaction() to accept UIActionSchema (enhanced action schema) instead of legacy CRUD ActionSchema.
  • Fix ConditionalAuthWrapper relative import paths for ObjectStackAdapter and LoadingScreen.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/core/src/actions/TransactionManager.ts Uses UIActionSchema for actionExecutor to match TransactionConfig.actions and resolve the TS2345 build error.
apps/console/src/components/ConditionalAuthWrapper.tsx Corrects relative imports to match the file’s actual location under components/, resolving console test failures.

@github-actions
Copy link

📦 Bundle Size Report

Package Size Gzipped
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 1.17KB 0.53KB
auth (AuthProvider.js) 5.93KB 1.44KB
auth (ForgotPasswordForm.js) 4.00KB 1.44KB
auth (LoginForm.js) 4.20KB 1.45KB
auth (RegisterForm.js) 5.66KB 1.59KB
auth (UserMenu.js) 3.40KB 1.22KB
auth (createAuthClient.js) 2.78KB 0.98KB
auth (createAuthenticatedFetch.js) 1.24KB 0.60KB
auth (index.js) 1.14KB 0.50KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 1.50KB 0.55KB
components (index.js) 1811.76KB 425.83KB
core (index.js) 0.75KB 0.32KB
create-plugin (index.js) 9.28KB 2.98KB
data-objectstack (index.js) 23.44KB 5.74KB
fields (index.js) 87.61KB 17.17KB
i18n (i18n.js) 2.03KB 0.77KB
i18n (index.js) 1.65KB 0.66KB
i18n (provider.js) 2.88KB 0.99KB
layout (index.js) 14.64KB 4.53KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (index.js) 1.03KB 0.50KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 4.42KB 1.27KB
mobile (usePullToRefresh.js) 2.41KB 0.80KB
mobile (useResponsive.js) 0.71KB 0.42KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 3.11KB 0.87KB
permissions (evaluator.js) 4.00KB 1.23KB
permissions (index.js) 0.85KB 0.40KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.52KB
permissions (usePermissions.js) 0.99KB 0.49KB
plugin-aggrid (AddressField-Bntpynvd.js) 3.05KB 0.76KB
plugin-aggrid (AgGridImpl-3Mmf2qrR.js) 7.04KB 2.33KB
plugin-aggrid (AutoNumberField-C1kBJaxh.js) 0.28KB 0.27KB
plugin-aggrid (FileField-BDwbJvor.js) 3.50KB 1.34KB
plugin-aggrid (FormulaField-BXNiyGoh.js) 0.52KB 0.38KB
plugin-aggrid (GeolocationField-Df3yYcM9.js) 4.46KB 1.50KB
plugin-aggrid (GridField-CcjQp4WM.js) 1.71KB 0.67KB
plugin-aggrid (LocationField-BIfN5QIq.js) 0.93KB 0.54KB
plugin-aggrid (MasterDetailField-CAEmxbIT.js) 3.86KB 1.17KB
plugin-aggrid (ObjectAgGridImpl-EjifM4aY.js) 919.77KB 203.53KB
plugin-aggrid (ObjectField-BpkQpIF-.js) 1.61KB 0.77KB
plugin-aggrid (QRCodeField-VCBewTDG.js) 3.38KB 1.23KB
plugin-aggrid (RichTextField-CyQwSi2C.js) 1.16KB 0.59KB
plugin-aggrid (SignatureField-Cr4tsEbj.js) 3.32KB 1.28KB
plugin-aggrid (SummaryField-CnEJ_GZI.js) 0.48KB 0.37KB
plugin-aggrid (UserField-DJjaVyrV.js) 2.44KB 0.93KB
plugin-aggrid (VectorField-cPYmcKnV.js) 0.79KB 0.44KB
plugin-aggrid (index-B87wd1E0.js) 19.95KB 5.03KB
plugin-aggrid (index.js) 0.22KB 0.16KB
plugin-ai (index.js) 25.45KB 6.36KB
plugin-calendar (index.js) 31.63KB 8.05KB
plugin-charts (AdvancedChartImpl-DFmeUY4Q.js) 124.69KB 25.93KB
plugin-charts (BarChart-C_I0OFbj.js) 542.77KB 135.30KB
plugin-charts (ChartImpl-B5LY4On3.js) 3.17KB 1.10KB
plugin-charts (index-DSBO2Kdy.js) 15.18KB 4.46KB
plugin-charts (index.js) 0.19KB 0.16KB
plugin-chatbot (index.js) 1140.69KB 333.05KB
plugin-dashboard (index.js) 138.23KB 36.00KB
plugin-designer (index.js) 43.02KB 9.48KB
plugin-detail (index.js) 1716.98KB 404.84KB
plugin-editor (MonacoImpl-hfdmoz6k.js) 18.15KB 5.59KB
plugin-editor (index-CuYbY6xb.js) 10.10KB 3.32KB
plugin-editor (index.js) 0.19KB 0.15KB
plugin-form (index.js) 52.17KB 10.49KB
plugin-gantt (index.js) 163.81KB 38.60KB
plugin-grid (index.js) 45.16KB 12.17KB
plugin-kanban (KanbanEnhanced-DjadKL5D.js) 31.43KB 9.03KB
plugin-kanban (KanbanImpl-BHAT_ney.js) 5.28KB 1.91KB
plugin-kanban (index-BhdljdIe.js) 17.29KB 5.01KB
plugin-kanban (index.js) 0.27KB 0.17KB
plugin-kanban (sortable.esm-ZHwgFQIO.js) 71.42KB 18.98KB
plugin-list (index.js) 1731.32KB 408.38KB
plugin-map (index.js) 126.32KB 30.52KB
plugin-map (maplibre-gl-CNsW26De.js) 1418.32KB 302.53KB
plugin-markdown (MarkdownImpl-DufQ-eRU.js) 256.68KB 64.45KB
plugin-markdown (index-CrmE78vF.js) 9.63KB 3.17KB
plugin-markdown (index.js) 0.19KB 0.15KB
plugin-report (index.js) 63.13KB 12.71KB
plugin-timeline (index.js) 105.30KB 24.14KB
plugin-view (index.js) 47.44KB 12.12KB
plugin-workflow (index.js) 30.88KB 7.14KB
react (LazyPluginLoader.js) 3.77KB 1.33KB
react (SchemaRenderer.js) 3.28KB 1.30KB
react (index.js) 0.39KB 0.25KB
react (index.test.js) 0.34KB 0.26KB
tenant (TenantContext.js) 0.31KB 0.25KB
tenant (TenantGuard.js) 1.04KB 0.43KB
tenant (TenantProvider.js) 2.76KB 0.98KB
tenant (TenantScopedQuery.js) 0.77KB 0.44KB
tenant (index.js) 0.75KB 0.38KB
tenant (resolver.js) 2.64KB 0.76KB
tenant (useTenant.js) 0.50KB 0.32KB
tenant (useTenantBranding.js) 0.62KB 0.39KB
types (ai.js) 0.20KB 0.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 0.20KB 0.18KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 0.20KB 0.18KB
types (crud.js) 0.20KB 0.18KB
types (data-display.js) 0.20KB 0.18KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 0.20KB 0.18KB
types (disclosure.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (index.js) 1.12KB 0.49KB
types (layout.js) 0.20KB 0.18KB
types (mobile.js) 0.20KB 0.18KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 0.20KB 0.18KB
types (plugin-scope.js) 0.20KB 0.18KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (tenant.js) 0.20KB 0.18KB
types (theme.js) 0.20KB 0.18KB
types (ui-action.js) 0.20KB 0.18KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB
types (workflow.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@hotlong hotlong merged commit 439dda0 into main Feb 10, 2026
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants