Skip to content

Conversation

@anas005
Copy link

@anas005 anas005 commented Jul 1, 2019

When initialising HAProxy using new HAProxy(), it asynchronously reads the pid file.
So, calling haproxy.reload() after initialising, results in pid as ""(empty string) as the pid file has not yet read.
This PR fixes the issue by using readFileSync for reading pid if there is no callback provided to Orchestrator.prototype.read

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 85.294% when pulling 51dc2c7 on anas005:master into 93d7bf9 on observing:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 85.294% when pulling 51dc2c7 on anas005:master into 93d7bf9 on observing:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants