Skip to content

Conversation

@exeldro
Copy link
Contributor

@exeldro exeldro commented Jan 11, 2023

Description

Move transition preview button to button box
Before:
image
After:
image

Motivation and Context

It is more clear that the button does not belong to the transition properties.
The preview button stays visible while editing the transition.

How Has This Been Tested?

On windows 64 bit by opening the properties of a stinger transition

Types of changes

  • Tweak (non-breaking change to improve existing functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@WizardCM WizardCM added Enhancement Improvement to existing functionality UI/UX Anything to do with changes or additions to UI/UX elements. labels Jan 11, 2023
@WizardCM
Copy link
Member

Overall I think this is a good idea, my only concern UX-wise is that it's right next to the Defaults button, which a user might accidentally click instead (though Cancel would undo it, so it's probably safe).

@exeldro
Copy link
Contributor Author

exeldro commented Jan 11, 2023

If people prefer this:
image
Only have to change the insert position from 1 to 2
The insert position should work as long as there is no help button added according to the order of buttons on:
https://doc.qt.io/qt-6/qdialogbuttonbox.html

@jp9000
Copy link
Member

jp9000 commented Jan 13, 2023

Your proposed change sounds fairly reasonable exeldro. what do you think matt?

@WizardCM
Copy link
Member

I'd worry about the non-standard UX, it'd be a bit inconsistent with buttons on other dialogs. Overall though, I'm OK with either option.

@GeorgesStavracas
Copy link
Member

GeorgesStavracas commented Jan 23, 2023

@Warchamp7 prefers the bottom-right approach

@exeldro exeldro force-pushed the transition_preview_button branch from ee8253b to d889703 Compare January 23, 2023 21:33
@exeldro
Copy link
Contributor Author

exeldro commented Jan 23, 2023

Changed to the bottom-right version:
image

@Warchamp7 Warchamp7 force-pushed the transition_preview_button branch from d889703 to be58798 Compare November 18, 2025 00:15
@Warchamp7
Copy link
Member

I've rebased this PR

@Warchamp7 Warchamp7 moved this to Ready For Review in OBS Studio 32.1 PR Considerations Nov 18, 2025
@Warchamp7 Warchamp7 force-pushed the transition_preview_button branch from be58798 to 5cccc66 Compare November 18, 2025 00:17
@RytoEX RytoEX changed the title UI: Move transition preview button to button box frontend: Move transition preview button to button box Dec 18, 2025
@RytoEX RytoEX force-pushed the transition_preview_button branch from 5cccc66 to f09ddca Compare December 18, 2025 22:37
Copy link
Member

@RytoEX RytoEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine.

@RytoEX RytoEX added this to the OBS Studio 32.1 milestone Dec 18, 2025
@RytoEX RytoEX requested review from PatTheMav and gxalpha December 18, 2025 23:23
@RytoEX RytoEX moved this from Ready For Review to Ready For Merge in OBS Studio 32.1 PR Considerations Dec 18, 2025
Copy link
Member

@gxalpha gxalpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a huge fan of this approach hacking into the internals of QDialogButtonBox, especially since the layout of the standard buttons can vary between operating systems (and nowhere does Qt guarantee that the QBoxLayout this relies on even exists, that's just an implementation detail and could change at any point).
However QDialogButtonBox::addButton exists, which I think would be a much better solution.

Also, git commit authorship by exeldro should probably be retained, that appears to have been lost in a (manual?) rebase.

@Warchamp7 Warchamp7 force-pushed the transition_preview_button branch 2 times, most recently from 98c9055 to 023c363 Compare December 25, 2025 17:53
@Warchamp7 Warchamp7 force-pushed the transition_preview_button branch from 023c363 to 1dec832 Compare December 25, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement Improvement to existing functionality UI/UX Anything to do with changes or additions to UI/UX elements.

Projects

Status: Ready For Merge

Development

Successfully merging this pull request may close these issues.

7 participants