Nested dune call fix (execution environment part) #12935
Merged
+48
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leonidas-from-XIV
force-pushed
the
nested-dune-call-part-ii
branch
2 times, most recently
from
893aeab to
a21316e
Compare
rgrinberg
reviewed
Dec 12, 2025
Leonidas-from-XIV
force-pushed
the
nested-dune-call-part-ii
branch
2 times, most recently
from
d393ddf to
687b68c
Compare
rgrinberg
reviewed
Dec 16, 2025
Leonidas-from-XIV
force-pushed
the
nested-dune-call-part-ii
branch
2 times, most recently
from
db38af0 to
7df6f1b
Compare
rgrinberg
reviewed
Dec 17, 2025
Leonidas-from-XIV
force-pushed
the
nested-dune-call-part-ii
branch
from
1fff8b4 to
e41d185
Compare
Signed-off-by: Marek Kubica <marek@tarides.com>
Signed-off-by: Marek Kubica <marek@tarides.com>
Signed-off-by: Marek Kubica <marek@tarides.com>
Signed-off-by: Marek Kubica <marek@tarides.com>
We don't register the dependency because we will not build it but we add it to the type to know whether the package depended on Dune. Signed-off-by: Marek Kubica <marek@tarides.com>
Leonidas-from-XIV
force-pushed
the
nested-dune-call-part-ii
branch
from
e41d185 to
a096108
Compare
Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a companion PR to #12902. Where #12902 resolves the
dunebinary to be called to be correct, this PR prepends an extra entry to thePATHvariable so the environment will point to the right dune instead of whatever was captured in the environment (potentially by accident).It has a non-essential dependency on #12916 to show that the Dune binary is correctly resolved in all cases.