feat: don't print entering/leaving directory message when no ouput #12974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ali Caglayan <alizter@gmail.com>
Alizter
force-pushed
the
push-zrowwsototzk
branch
from
f0d32fc to
2e254ba
Compare
rgrinberg
reviewed
Dec 15, 2025
| before the first call to [print_user_message]. The suffix is printed at | ||
| [finish] time, but only if the prefix was printed (i.e., there was output). | ||
| Can only be called once. *) | ||
| val set_prefix_and_suffix |
Member
There was a problem hiding this comment.
Why do we need this layer of indirection? Why don't we just move the printing of these messages to dune_console?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--display=quiethas no effect on--root-changing messages #12854