Skip to content

Conversation

@benodiwal
Copy link
Contributor

Closes #12343

NOTE: Deleted timeout-no-command.t as it tested the old behavior (timeouts not showing which command failed). This is now covered by the new timeout-partial-promotion.t test.

@benodiwal
Copy link
Contributor Author

Require some input on the direction and the output present in test files.

@Alizter Alizter self-requested a review December 16, 2025 08:10
@Alizter
Copy link
Collaborator

Alizter commented Dec 16, 2025

This is a good start but I would rather that the error semantics for a timed out cram test are preserved. Essentially such a failing cram test would produce two errors where one is a diff and the other is a timeout.

I have a WIP branch here https://github.com/Alizter/dune/tree/push-oowqxypwmrtn which I haven't had time to rebase recently. It involves a number of changes but mainly adds locations to the cram error messages, offers partial promotions and allows for both diffs and errors to be raised together.

I do plan to come back to this but I don't want to stop you from making progress here, so please feel free to inspect the branch and pick out anything that will help you improve this PR. The tests there are also worth reading so that you can get an idea of the semantics I was going for.

@benodiwal benodiwal changed the title feat: cram tests that timeout now offer partial promotion [WIP] feat: cram tests that timeout now offer partial promotion Dec 17, 2025
@benodiwal benodiwal marked this pull request as draft December 17, 2025 15:11
Signed-off-by: Sachin Beniwal <s474996633@gmail.com>
Signed-off-by: Sachin Beniwal <s474996633@gmail.com>
@benodiwal benodiwal force-pushed the cram-timeout-partial-promotion branch 3 times, most recently from 435df0d to d5c87c3 Compare December 17, 2025 17:26
@Alizter Alizter self-requested a review December 17, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Timed out cram tests should offer partial promotions

2 participants