Skip to content

dune: Fix top-level installation #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jtojnar wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

dune: Fix top-level installation #87

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions dune
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,23 @@
(modules generate)
(libraries stdcompat))

(rule
(target pymltop_libdir.ml)
(action (with-stdout-to %{target}
(run echo "let libdir=\"%{project_root}/lib/pyml/\""))))
Copy link
Author

@jtojnar jtojnar Oct 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how to get the prefix in dune so I just put in project root as a placeholder. We need to replicate

https://github.com/thierry-martinez/pyml/blob/d9d404536b3e60a74bd61c0e58812ed8c5811109/Makefile#L352-L357


(executable
(name pytop)
(public_name pymltop)
(modules pytop pymltop_libdir)
(libraries compiler-libs))

(executable
(name pyutop)
(public_name pymlutop)
(modules pyutop)
(libraries utop))

(rule
(targets pywrappers.ml pyml.h pyml_dlsyms.inc pyml_wrappers.inc)
(deps (:gen generate.exe))
Expand Down