Skip to content

Feat/1134 common error system tests #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ndrpp wants to merge 2 commits into
base: main
Choose a base branch
from
+69 −45
Open

Feat/1134 common error system tests #138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3fcf82
feat: display stderr logs in unit tests
ndrpp Jan 12, 2026
412dceb
chore: cleanup
ndrpp Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 44 additions & 33 deletions src/commands.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,7 @@
}
}


public async initializeCompute(args: string[]) {
const inputDatasetsString = args[1];
let inputDatasets = [];
Expand Down Expand Up @@ -294,7 +295,6 @@
if (ddos.length > 0) {
providerURI = ddos[0].services[0].serviceEndpoint;
}

const algoDdo = await this.aquarius.waitForIndexer(
args[2],
null,
Expand Down Expand Up @@ -517,7 +517,7 @@
inputDatasets.length > 0 &&
(ddos.length <= 0 || ddos.length != inputDatasets.length)
) {
console.error("Not all the data ddos are available.");
console.error(`DDO count mismatch. Expected: ${inputDatasets.length}, Got: ${ddos.length}`);
return;
}
let providerURI = this.oceanNodeUrl;
Expand All @@ -532,9 +532,7 @@
this.indexingParams.maxRetries
);
if (!algoDdo) {
console.error(
"Error fetching DDO " + args[1] + ". Does this asset exists?"
);
console.error("FAILED to fetch algorithm DDO " + args[2] + ". Does this asset exists?");
return;
}

Expand All @@ -544,10 +542,11 @@

if (!computeEnvs || computeEnvs.length < 1) {
console.error(
"Error fetching compute environments. No compute environments available."
"FAILED - No compute environments available from provider"
);
return;
}

const computeEnvID = args[3];
// NO chainId needed anymore (is not part of ComputeEnvironment spec anymore)
// const chainComputeEnvs = computeEnvs[computeEnvID]; // was algoDdo.chainId
Expand All @@ -563,9 +562,9 @@
}
if (!computeEnv || !computeEnvID) {
console.error(
"Error fetching compute environment. No compute environment matches id: ",
computeEnvID
"FAILED - No compute environment matches id: " + computeEnvID
);
console.error("Available environment IDs: ", computeEnvs.map(e => e.id));
return;
}

Expand Down Expand Up @@ -615,7 +614,7 @@
);
if (!algo.transferTxId) {
console.error(
"Error ordering compute for algorithm with DID: " +
"FAILED - Error ordering compute for algorithm with DID: " +
args[2] +
". Do you have enough tokens?"
);
Expand All @@ -637,8 +636,8 @@
);
if (!assets[i].transferTxId) {
console.error(
"Error ordering dataset with DID: " +
assets[i] +
"FAILED - Error ordering dataset with DID: " +
ddos[i].id +
". Do you have enough tokens?"
);
return;
Expand Down Expand Up @@ -729,7 +728,7 @@
getAddress(parsedProviderInitializeComputeJob.payment.escrowAddress),
this.signer
)
console.log("Verifying payment...");
console.log("Verifying escrow payment...");
await new Promise(resolve => setTimeout(resolve, 3000))

const validationEscrow = await escrow.verifyFundsForEscrowPayment(
Expand All @@ -742,16 +741,15 @@
)
if (validationEscrow.isValid === false) {
console.error(
"Error starting compute job dataset DID " +
"FAILED - Escrow funds check failed for dataset DID " +
args[1] +
" and algorithm DID " +
args[2] +
" because escrow funds check failed: "
" because: "
+ validationEscrow.message
);
return;
}

console.log("Starting compute job using provider: ", providerURI);

const additionalDatasets = assets.length > 1 ? assets.slice(1) : null;
Expand Down Expand Up @@ -781,23 +779,36 @@
metadataUri: await getMetadataURI(),
};

const computeJobs = await ProviderInstance.computeStart(
providerURI,
this.signer,
computeEnv.id,
assets, // assets[0] // only c2d v1,
algo,
supportedMaxJobDuration,
paymentToken,
JSON.parse(resources),
Number((await this.signer.provider.getNetwork()).chainId),
null,
null,
// additionalDatasets, only c2d v1
output
);
let computeJobs;
try {
computeJobs = await ProviderInstance.computeStart(
providerURI,
this.signer,
computeEnv.id,
assets, // assets[0] // only c2d v1,
algo,
supportedMaxJobDuration,
paymentToken,
JSON.parse(resources),
Number((await this.signer.provider.getNetwork()).chainId),
null,
null,
// additionalDatasets, only c2d v1
output
);
} catch (error) {
// Check for specific error types
if ((error as any)?.code === 'ECONNREFUSED') {

Check warning on line 801 in src/commands.ts

View workflow job for this annotation

GitHub Actions / lint 

Unexpected any. Specify a different type
console.log("DEBUG: ⚠️ CONNECTION REFUSED - Ocean node may not be running at: ", providerURI);
} else if ((error as any)?.code === 'ETIMEDOUT') {

Check warning on line 803 in src/commands.ts

View workflow job for this annotation

GitHub Actions / lint 

Unexpected any. Specify a different type
console.log("DEBUG: ⚠️ TIMEOUT - Ocean node did not respond in time");
} else if (error?.message?.includes('fetch')) {
console.log("DEBUG: ⚠️ NETWORK ERROR - Failed to make HTTP request");
}

console.log("computeJobs: ", computeJobs);
console.log("Error calling ProviderInstance.computeStart: ", error);
return;
}

if (computeJobs && computeJobs[0]) {
const { jobId, payment } = computeJobs[0];
Expand Down Expand Up @@ -1466,13 +1477,13 @@
const initialUsers = args[3] ? args[3].split(',').map(u => u.trim()) : [];

if (!name || !symbol) {
console.error(chalk.red('Name and symbol are required'));
console.error('Name and symbol are required');
return;
}

const config = await getConfigByChainId(Number(this.config.chainId));
if (!config.AccessListFactory) {
console.error(chalk.red('Access list factory not found. Check local address.json file'));
console.error('Access list factory not found. Check local address.json file');
return;
}
const accessListFactory = new AccesslistFactory(
Expand Down Expand Up @@ -1614,7 +1625,7 @@

console.log(chalk.green(`✓ Successfully removed user ${user} (token ID: ${tokenId})`));
removedCount++;
} catch (e: any) {

Check warning on line 1628 in src/commands.ts

View workflow job for this annotation

GitHub Actions / lint 

Unexpected any. Specify a different type
console.log(chalk.yellow(`⚠ Could not remove token at index ${index} for user ${user}: ${e.message}`));
}
}
Expand Down
17 changes: 12 additions & 5 deletions test/interactivePublishFlow.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,13 @@ import { fileURLToPath } from 'url'

const __filename = fileURLToPath(import.meta.url)
const __dirname = dirname(__filename)
describe("Ocean CLI Interactive Publishing", function() {
describe("Ocean CLI Interactive Publishing", function () {
this.timeout(120000); // Set a longer timeout to allow for user input simulation

const projectRoot = path.resolve(__dirname, "..");
let publishedDid: string;

it("should publish an asset using 'npm run cli start' interactive flow", function(done) {
it("should publish an asset using 'npm run cli start' interactive flow", function (done) {
process.env.PRIVATE_KEY = "0x1d751ded5a32226054cd2e71261039b65afb9ee1c746d055dd699b1150a5befc";
process.env.RPC = "http://127.0.0.1:8545";
process.env.NODE_URL = "http://127.0.0.1:8001";
Expand Down Expand Up @@ -56,12 +56,16 @@ describe("Ocean CLI Interactive Publishing", function() {
fullOutput += data.toString();
});

child.stderr?.on('data', (data) => {
console.error(data.toString());
});

child.on('close', (code) => {
try {
expect(code).to.equal(0);
expect(fullOutput).to.contain("Asset successfully published with DID:");
expect(fullOutput).to.contain("Metadata successfully updated for DID:");

const match = fullOutput.match(/did:op:[a-f0-9]{64}/);
if (match) {
publishedDid = match[0];
Expand All @@ -77,8 +81,11 @@ describe("Ocean CLI Interactive Publishing", function() {
});
});

it("should get DDO using 'npm run cli getDDO' for the published asset", function(done) {
exec(`npm run cli getDDO ${publishedDid}`, { cwd: projectRoot }, (error, stdout) => {
it("should get DDO using 'npm run cli getDDO' for the published asset", function (done) {
exec(`npm run cli getDDO ${publishedDid}`, { cwd: projectRoot }, (error, stdout, stderr) => {
if (stderr) {
console.error(stderr);
}
try {
expect(stdout).to.contain(`${publishedDid}`);
expect(stdout).to.contain("https://w3id.org/did/v1");
Expand Down
15 changes: 9 additions & 6 deletions test/setup.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,19 +7,22 @@ import { fileURLToPath } from 'url'

const __filename = fileURLToPath(import.meta.url)
const __dirname = dirname(__filename)
describe("Ocean CLI Setup", function() {
describe("Ocean CLI Setup", function () {
process.env.AVOID_LOOP_RUN = "true";
this.timeout(20000); // Set a longer timeout to allow the command to execute

it("should return a valid response for 'npm run cli h'", function(done) {
it("should return a valid response for 'npm run cli h'", function (done) {
// Ensure the command is run from the project root directory
const projectRoot = path.resolve(__dirname, "..");

// Set environment variables for the test
process.env.PRIVATE_KEY = "0x1d751ded5a32226054cd2e71261039b65afb9ee1c746d055dd699b1150a5befc";
process.env.RPC = "http://127.0.0.1:8545";

exec("npm run cli h", { cwd: projectRoot }, (error, stdout) => {
exec("npm run cli h", { cwd: projectRoot }, (error, stdout, stderr) => {
if (stderr) {
console.error(stderr);
}
// Check the stdout for the expected response
try {
expect(stdout).to.contain("help|h");
Expand Down Expand Up @@ -69,7 +72,7 @@ describe("Ocean CLI Setup", function() {
});

// Additional comprehensive tests
it("should return an error message when only MNEMONIC is set", function(done) {
it("should return an error message when only MNEMONIC is set", function (done) {
const projectRoot = path.resolve(__dirname, "..");
process.env.MNEMONIC = "your-valid-mnemonic-here";
delete process.env.PRIVATE_KEY;
Expand All @@ -85,7 +88,7 @@ describe("Ocean CLI Setup", function() {
});
});

it("should return an error message when only PRIVATE_KEY is set", function(done) {
it("should return an error message when only PRIVATE_KEY is set", function (done) {
const projectRoot = path.resolve(__dirname, "..");
delete process.env.MNEMONIC;
process.env.PRIVATE_KEY = "0x1d751ded5a32226054cd2e71261039b65afb9ee1c746d055dd699b1150a5befc";
Expand All @@ -101,7 +104,7 @@ describe("Ocean CLI Setup", function() {
});
});

it("should return an error message when only RPC is set", function(done) {
it("should return an error message when only RPC is set", function (done) {
const projectRoot = path.resolve(__dirname, "..");
delete process.env.MNEMONIC;
delete process.env.PRIVATE_KEY;
Expand Down
5 changes: 4 additions & 1 deletion test/util.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,10 @@ export const projectRoot = path.resolve(__dirname, "..");
export const runCommand = async (command: string): Promise<string> => {
console.log(`\n[CMD]: ${command}`);
try {
const { stdout } = await execPromise(command, { cwd: projectRoot });
const { stdout, stderr } = await execPromise(command, { cwd: projectRoot });
if (stderr) {
console.error(`[STDERR]:\n${stderr}`);
}
console.log(`[OUTPUT]:\n${stdout}`);
return stdout;
} catch (error: any) {
Expand Down
Loading