Skip to content

Fix memory leak in radTInteraction::EmptyVectOfPtrToListsOfTrans #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
per-gron wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix memory leak in radTInteraction::EmptyVectOfPtrToListsOfTrans #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cpp/src/core/radintrc.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,14 +266,14 @@ inline void radTInteraction::PushFrontNativeElemTransList(radTg3d* g3dPtr, radTl

inline void radTInteraction::EmptyVectOfPtrToListsOfTrans()
{
for(unsigned i=1; i<IntVectOfPtrToListsOfTransPtr.size(); i++)
for(unsigned i=0; i<IntVectOfPtrToListsOfTransPtr.size(); i++)
Copy link
Owner

@ochubar ochubar Dec 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. I'll make more tests / debugging, and will probably merge this.

{
radTlphgPtr*& p_lphgPtr = IntVectOfPtrToListsOfTransPtr[i];
if(p_lphgPtr != 0) delete p_lphgPtr;
p_lphgPtr = 0;
}
IntVectOfPtrToListsOfTransPtr.erase(IntVectOfPtrToListsOfTransPtr.begin(), IntVectOfPtrToListsOfTransPtr.end());
for(unsigned k=1; k<ExtVectOfPtrToListsOfTransPtr.size(); k++)
for(unsigned k=0; k<ExtVectOfPtrToListsOfTransPtr.size(); k++)
{
radTlphgPtr*& p_lphgPtr = ExtVectOfPtrToListsOfTransPtr[k];
if(p_lphgPtr != 0) delete p_lphgPtr;
Expand Down