-
Notifications
You must be signed in to change notification settings - Fork 198
Implementation of effects based on the Stack Switching proposal #1832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
49e1043 to
f368877
Compare
3b9ce6d to
3f4555c
Compare
a8763e2 to
4d6ce8e
Compare
5c5211c to
41291bc
Compare
2fd57df to
226063f
Compare
5e8405e to
83474da
Compare
0017456 to
c27e0c1
Compare
13e9b8f to
9396373
Compare
ab70126 to
bf729a1
Compare
|
Hi! We are working on Wizard's stack switching and would like to generate benchmarks with |
Wasmtime only supports these instructions. We should eventually use instead of the legacy instructions, but they are not allowed by default in node.
bf729a1 to
1f521fd
Compare
|
Hi! This was done in #2134. I have rebased the PR. We originally forced a source install because prebuilt versions of binaryen 1.24+ weren't available. Now that they are, that step isn't needed anymore. For a long time we this faked the installation of binaryen on the CI with |
1f521fd to
4a2b500
Compare
To generate Wasm code that makes use of the Stack Switching proposal, you first need to install the development version of Binaryen (or version 124 once it is released).
Then, you need to run
wasm_of_ocamlwith the--enable wasiflag:This produces some Wasm code that can be directly executed by the Wizard engine:
Note that we keep the same output convention, at least for now: a JavaScript file
foo.jsand a directoryfoo.assetscontaining the Wasm code. The JavaScript file should be useful to run the tests withnodeonce it supports this extension. It is used at the moment in #1831 to test the WASI runtime.