Fix pin on Windows #196
Merged
Fix pin on Windows #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shonfeder
approved these changes
Jan 17, 2025
| | Linux | ||
| | OpenBSD -> Lwt.return_unit | ||
| | Windows -> | ||
| (* if the junction isn't removed and the target drive is missing, then `mkdir -p <dst>/foo` fails *) |
Member
There was a problem hiding this comment.
What does "junction" mean in this context?
Member
Author
There was a problem hiding this comment.
A "junction", or more fully, an NTFS junction point, is a specific type of file system symbolic link available on NTFS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under Windows, we map access to download caches through NTFS junction points. This effectively creates a file system directory which links to the cache drive. However, we did not remove the junction points when the cache is not present. During an
opam pin, opam tries to create a folder under thedownload-cache/gitdirectory (with no cache present). The junction refers to a location which doesn't exist at this time and therefore the opam command fails. This PR removes the junction when the cache is removed.