Conversation
|
Could you reword the first commit so that "Update the Rapidjson libary to version 1.1.0" is in the subject instead of the body? Let me know if you need help with this. |
Ohisemega
force-pushed
the
update_to_c++17
branch
from
08bdc5e to
4570805
Compare
|
Hi Gary
Yes, I've done this! |
Ohisemega
force-pushed
the
update_to_c++17
branch
from
4570805 to
5286d43
Compare
Ohisemega
force-pushed
the
update_to_c++17
branch
2 times, most recently
from
5286d43 to
98c65e2
Compare
Ohisemega
force-pushed
the
update_to_c++17
branch
from
438a84b to
3ac6ef6
Compare
Update the Rapidjson library to version 1.1.0
Remove boost::shared_ptr, boost::optional, boost::bind, boost::mutex, boost::to_string, boost::lexical_cast<std::string>, boost::function, etc Replace the above boost libraries with std equivalent
Add Move constructor and assignment operator to: 1. Frame class 2. FrameMetaData class Replace push_back with emplace_back in scenarios where rvalue moves are feasible. Use move semantics to elid construction of tempoary objects.
Ohisemega
force-pushed
the
update_to_c++17
branch
from
3ac6ef6 to
cde8761
Compare
Add return value for move and copy constructor of FrameMetaData class Change instance of boost::shared_ptr to std::shared_ptr
Replace FrameProcessorController's "static const std::string" members with "static const std::string_view" Reimplement the IpcMessage's get_param(const std::string param_name) to get_param(const std::string_view param_name) Reimplement the IpcMessage's has_param(const std::string param_name) to has_param(const std::string_view param_name) Reimplement the IpcMessage's internal_set_param(const std::string param_name, T const& param_value) to internal_set_param(const std::string_view param_name, T const& param_value)
Change OdinDataDefault const std::string to const std::string_view Change FrameReceiver configuration string from const std::string to const std::string_view Reformat set_param(const std::string param_name, T const& param_value) to set_param(const std::string_view param_name, T const& param_value) Modify FrameReceiverConfig.h to convert
|
Hi @Ohisemega , to make this easier to progress it would be better if we can split it into multiple smaller PRs which can then be reviewed and potentially merged. |
- Return instatiated std::shared_ptr from std::shared_ptr<BaseClass> maker() - Change IpcMessage methods to take const std::string_view& - In ParamContainer.h remove std::move() call on val - Remove 'acquisition_ID_ = frame.acquisition_ID_' from FrameMetaData's move-constructor
Ohisemega
added
enhancement
Awaiting review/approval
Hi Alan! Pardon my late response to this message @ajgdls . I would create a new issue in that case and open a new PR. |
3 participants
Update Codebase to C++17 Standard
Remove boost::shared_ptr, boost::optional, boost::bind, boost::mutex, boost::to_string, boost::lexical_caststd::string, boost::function, etc
Replace the above boost libraries with std:: equivalent.
Update the Rapidjson library to version 1.1.0