Update BLOSC Settings As String#401
Open
Ohisemega wants to merge 8 commits intoodin-detector:masterfrom
Open
Conversation
Update Blosc Setting - shuffle from int to std::string. Update Blosc Setting - blosc_compressor from int to std::string. Add conversion function mapping from unsigned int to std::string shuffle_i2str. Add conversion function mapping from unsigned int to std::string compressor_i2str. Add hash-maps from std::string to unsigned int - shuffle_str2i and compressor_str2i. Update references to shuffle and blosc_compressor, to map to required format. Fixes odin-detector#204
This comment was marked as off-topic.
This comment was marked as off-topic.
Fix bugs. Improve code structure. Fixes odin-detector#204
GDYendell
previously requested changes
May 15, 2025
Collaborator
GDYendell
left a comment
GDYendell
left a comment
There was a problem hiding this comment.
This looks pretty good. Just a few comments.
Remove redundant int-to-string conversion functions in BloscPlugin library. Fix formatting in BloscPlugin.cpp Make inherited methids in BloscPlugin from FrameProcessPlugin public. Make configurtion strings in BloscPlugin library public. Add Unit test for configure method of BloscPlugin. Fixes odin-detector#204
Restore the commanded_compression_settings_ parameter in the requestConfiguration() method of BloscPlugin library.
GDYendell
reviewed
May 19, 2025
Change shuffle config to lowercase.
Ohisemega
added
ready
blocked
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Blosc Setting - shuffle from int to std::string.
Update Blosc Setting - blosc_compressor from int to std::string.
Add conversion function mapping from unsigned int to std::string shuffle_i2str.
Add conversion function mapping from unsigned int to std::string compressor_i2str.
Add hash-maps from std::string to unsigned int - shuffle_str2i and compressor_str2i.
Update references to shuffle and blosc_compressor, to map to required format.
Fixes #204