Skip to content

Implement FileWriterPlugin Metadata Fix Issue 408#424

Open
Ohisemega wants to merge 1 commit intoImplement_Core_Plugins_Metadata_Fix_ISSUE_408from
Implement_Metadata_FileWriterPlugin_Fix_Issue_408
Open

Implement FileWriterPlugin Metadata Fix Issue 408#424
Ohisemega wants to merge 1 commit intoImplement_Core_Plugins_Metadata_Fix_ISSUE_408from
Implement_Metadata_FileWriterPlugin_Fix_Issue_408

Conversation

@Ohisemega
Copy link
Contributor

FileWriterPlugin Metadata Implementation

@Ohisemega Ohisemega changed the base branch from master to Implement_Core_Plugins_Metadata_Fix_ISSUE_408 November 5, 2025 17:43
@Ohisemega Ohisemega added this to the in-progress milestone Nov 6, 2025
@Ohisemega Ohisemega self-assigned this Nov 6, 2025
@Ohisemega Ohisemega added bug in progress Awaiting review/approval Has been addressed in a PR and needs to be approved or commented for rework by a reviewer labels Nov 6, 2025
@Ohisemega Ohisemega force-pushed the Implement_Metadata_FileWriterPlugin_Fix_Issue_408 branch 4 times, most recently from ef9666d to d872a0f Compare November 6, 2025 10:47
@Ohisemega Ohisemega removed the bug label Nov 6, 2025
@Ohisemega
Copy link
Contributor Author

Ohisemega commented Nov 6, 2025

@ajgdls and @GDYendell, I was wondering if we need an associated method to clean up the configuration metadata parameter container in FileWritePlugin. This is because we have a method FileWriterPlugin::delete_datasets() which cleans the dataset_ defs_ map in the plugin. The logic follows that if the dataset definition is "purged", then the associated metadata parameters in the metadata map container are invalid too. What do you think?

/**
 * Deletes all dataset definitions from the plugin.
 */
void FileWriterPlugin::delete_datasets()
{
  LOG4CXX_INFO(logger_, "Deleting all datasets from FileWriter plugin");
  dataset_defs_.clear();
}

@Ohisemega Ohisemega changed the title Implement metadata file writer plugin fix issue 408 Implement FileWriterPlugin Metadata Fix Issue 408 Nov 7, 2025
GDYendell

This comment was marked as resolved.

@Ohisemega Ohisemega requested a review from GDYendell November 11, 2025 10:37
@Ohisemega Ohisemega force-pushed the Implement_Metadata_FileWriterPlugin_Fix_Issue_408 branch from 3db7e27 to 853f04f Compare November 11, 2025 12:12
@Ohisemega Ohisemega linked an issue Nov 12, 2025 that may be closed by this pull request
@GDYendell GDYendell force-pushed the Implement_Core_Plugins_Metadata_Fix_ISSUE_408 branch 3 times, most recently from 60f50d4 to a13f9a2 Compare February 9, 2026 15:16
@GDYendell GDYendell force-pushed the Implement_Metadata_FileWriterPlugin_Fix_Issue_408 branch from abe23fe to 7c412cb Compare February 9, 2026 15:36
@GDYendell GDYendell force-pushed the Implement_Metadata_FileWriterPlugin_Fix_Issue_408 branch from 7c412cb to 9a8e4c8 Compare February 9, 2026 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Awaiting review/approval Has been addressed in a PR and needs to be approved or commented for rework by a reviewer ready

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement meta data for odin-data core plugins

3 participants