Open
Conversation
Initial Commit Add TmpFSPlugin *.cpp, *Lib.cpp and *.h files. Fixes #434
Contributor
Author
|
@GDYendell @ajgdls |
Ohisemega
added
enhancement
in progress
Awaiting review/approval
Change Plugin and rlated files to have TempfsPlugin prefix. Add instruction to write to opened file. Remove comments related to "removing file." Remove comments related to data pointer source. Fix error and exception logs. Move "Create directory" step to process_frame() function. Fixes #434
Contributor
Author
|
Personal Note: Write UNIT Test for TempfsPlugin |
Add Acquisition Number and Frame Number to file path creation of TmpfsPlugin::process_frame() method. Fixes #434
GDYendell
reviewed
Feb 11, 2026
Add '/' in-between acquisiton_ID and Frame number. Remove erratic BLOSC guard header prefixes. Improve code comment for full_file_path_ data member. Fixes #434
GDYendell
reviewed
Feb 11, 2026
| strerror_r(errno, msg.data(), msg.max_size()); | ||
| error << "Failed to Write to file - " << this->full_file_path_.string() <<": " << msg.data(); | ||
| throw std::runtime_error(error.str()); | ||
| } |
Collaborator
There was a problem hiding this comment.
In eiger-detector we added this nice helper:
#define LOG_WITH_ERRNO(log, message) \
std::stringstream error; \
{ \
error << message << " [errno: " << errno << " - " << strerror(errno) << "]"; \
std::stringstream error; \
LOG4CXX_ERROR(log, error.str()); \
error << message << " [errno: " << errno << " - " << strerror(errno) << "]"; \
}
LOG4CXX_ERROR(log, error.str()); \
}but it sounds like strerror_r is better because it is threadsafe?
Contributor
Author
There was a problem hiding this comment.
Yes strerrno_r() is thread-safe and re-entrant.
GDYendell
reviewed
Feb 11, 2026
GDYendell
reviewed
Feb 11, 2026
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Add boolean flag to indicate a failed directory creation. Add return-early condition to process_frame() function if boolean is TRUE. Set error messages in plugin's error_message bucket. Fixes #434
Rename TmpfsPlugin to RawFileWriterPlugin and all related files and library names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial Commit
Add TmpFSPlugin *.cpp, *Lib.cpp and *.h files.
Fixes #434