Skip to content
This repository was archived by the owner on Jan 27, 2019. It is now read-only.

Conversation

@esben
Copy link
Contributor

@esben esben commented Jan 17, 2016

This is a cherry pick of most of the commits in the old PR #13 from @diorcety.

@esben esben mentioned this pull request Jan 17, 2016
@esben esben modified the milestone: 5.0.0 Jan 17, 2016
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@diorcety where do you expect to get native:makeinfo from? Did you send a PR with makeinfo recipe, or should it be added to ASSUME_PROVIDED?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. We should get that merged then :)

But what about adding native:makeinfo to conf/provided/minimal.conf also?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be. But all these PRs have goal to have the minimal provided tool (a minimal minimal)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Maybe we should only add it to default.conf and all.conf instead then.
That is probably both the right thing, and will allow us to build test this PR without the texinfo recipe merged in OE-lite/base.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agreed. So we let the PR like this and i create the PR for texinfo into base?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should add native:makeinfo to default.conf and all.conf in this PR, so we can merge it independently of changes in base.

And creating a PR for texinfo in base would be great.

@esben esben force-pushed the diorcety-improvements branch from 1b698aa to d27de9f Compare January 19, 2016 07:20
esben added a commit that referenced this pull request Jan 20, 2016
Cherry-pick of commits from old PR #13
@esben esben merged commit 2e38070 into oe-lite:master Jan 20, 2016
@esben esben removed the in progress label Jan 20, 2016
@esben esben deleted the diorcety-improvements branch February 2, 2016 07:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants