-
Notifications
You must be signed in to change notification settings - Fork 17
Cherry-pick of commits from old PR #13 #89
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@diorcety where do you expect to get native:makeinfo from? Did you send a PR with makeinfo recipe, or should it be added to ASSUME_PROVIDED?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. We should get that merged then :)
But what about adding native:makeinfo to conf/provided/minimal.conf also?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be. But all these PRs have goal to have the minimal provided tool (a minimal minimal)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Maybe we should only add it to default.conf and all.conf instead then.
That is probably both the right thing, and will allow us to build test this PR without the texinfo recipe merged in OE-lite/base.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agreed. So we let the PR like this and i create the PR for texinfo into base?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should add native:makeinfo to default.conf and all.conf in this PR, so we can merge it independently of changes in base.
And creating a PR for texinfo in base would be great.
Signed-off-by: Esben Haabendal <esben@haabendal.dk>
1b698aa to
d27de9f
Compare
Cherry-pick of commits from old PR #13
This is a cherry pick of most of the commits in the old PR #13 from @diorcety.