Conversation
The newly introduced functions now return if the graph was updated. The change from _weld_edges to _remove_useless_forks also removes dead ends. Note that they require an attribute "type" to make the funtion work.
Contributor
|
Hi, thanks for all the hard work updating the project! Just from a quick glance, it seems like the new |
Member
Author
This will help to reconstruct the original paths, e.g. for plotting.
… feature/improved_welding
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The current graph pre-processing code has the problem that it keeps detours if there are forks on the shorter path. Further, the current "welding" code is slow. This PR is to tackle both, using
networkxas a vehicle for efficient graph algorithms.