-
Notifications
You must be signed in to change notification settings - Fork 2
Fix tags overflowing outside the card #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
We should have also css elipsis |
|
@44yu5h thank you ; can you please check how it looks like at every screen dimension? There are a lot of differences at different sizes and you mx might not work for all use cases (haven't looked at it though). As @kelson42 suggests (I think), the cut-out is a bit harsh and a visual clue that the text is too long would possibly be better. We do use ellipsis on title if it's too long so I guess we could use it here as well. Simply setting the width and the overflow ellipsis does it. @siemsie would an ellipsis be OK? |
Okay, will do! @siemsie Wow! These edits look so good. Which software do you use? I'll add the multiline support, ellipsis, tooltip, and increase the maximum number of tags (currently set to 2) |
|
Hi @44yu5h. Thanks – I use Adobe Illustrator, useful tool for quick solutions like this, although not too useful for web. |
fac539d to
317dc65
Compare
|
I also noticed the number of columns as |
|
Could you align the tags to the full width of the box, as model above. Thanks |
I think that space was reserved for the file size of the item. It was already there so I am guessing we had plans of showing that in the future? Let me know if you'd still want me to remove the space. |
|
@rgaudin Removed the extra space. Let me know if everything is alright now. Thanks |
|
@44yu5h sorry about the loooooonnng delay in replying. I had the notification aside for review and must have cleared it at some point. It doesn't work as suggested: there's no space between tags and there's a huge blank space below on every card now.
|




Fixes #34
New behaviour: